Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: components/payments/content/payment_request.cc

Issue 2772103002: [Payments] Desktop: never return false in incognito mode for canMakePayment (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/payments/content/payment_request.cc
diff --git a/components/payments/content/payment_request.cc b/components/payments/content/payment_request.cc
index fba230e1d8f5c5030a324e5746139a7881a6a894..f8d0b91c0f112219d871c4ded8c907607b03567c 100644
--- a/components/payments/content/payment_request.cc
+++ b/components/payments/content/payment_request.cc
@@ -85,8 +85,9 @@ void PaymentRequest::Complete(payments::mojom::PaymentComplete result) {
void PaymentRequest::CanMakePayment() {
// TODO(crbug.com/704676): Implement a quota policy for this method.
+ // PaymentRequest.canMakePayments() never returns false in incognito mode.
client_->OnCanMakePayment(
- state()->CanMakePayment()
+ delegate_->IsIncognito() || state()->CanMakePayment()
? mojom::CanMakePaymentQueryResult::CAN_MAKE_PAYMENT
: mojom::CanMakePaymentQueryResult::CANNOT_MAKE_PAYMENT);
}

Powered by Google App Engine
This is Rietveld 408576698