Implement comparison operators for base::Value

Implement comparison operators for base::Value

This change implements comparison operators for base::Value and deprecates the existing |Equals| methods.

BUG=646133
Review-Url: https://codereview.chromium.org/2771923005
Cr-Commit-Position: refs/heads/master@{#460162}
Committed: https://chromium.googlesource.com/chromium/src/+/5c1cee11c5b383689a81cc5b0c8f65803cef2f33

[jdoerrie, 2017-03-24 14:06:28]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 14:06:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 14:55:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 14:55:24]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[jdoerrie, 2017-03-24 16:25:42]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 16:26:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdoerrie, 2017-03-24 16:27:23]

Description was changed from

==========
Inline Comparisons


First Round

BUG=
==========

to

==========
Implement comparison operators for base::Value

This change implements comparison operators for base::Value and deprecates the
existing |Equals| methods.

BUG=646133
==========

[jdoerrie, 2017-03-24 16:27:23]

jdoerrie@chromium.org changed reviewers:
+ brettw@chromium.org

[jdoerrie, 2017-03-24 16:28:41]

jdoerrie@chromium.org changed reviewers:
+ stevenjb@chromium.org

[jdoerrie, 2017-03-24 16:33:16]

brettw@, please review base/value.*

stevenjb@, please review
chrome/browser/ui/webui/options/preferences_browsertest.cc

I was concerned that inlining the operators would have a bad impact on the
binary size, but testing locally I found out that there is only a 4KB (or
0.003%) increase for a branded official build. So it seems to be fine in my
opinion.

https://codereview.chromium.org/2771923005/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/preferences_browsertest.cc (left):

https://codereview.chromium.org/2771923005/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/preferences_browsertest.cc:76: void
PrintTo(const base::Value& value, std::ostream* stream) {
Given the presence of |std::ostream& operator<<(std::ostream& out, const Value&
value)| that pretty much does the same thing I feel like this can be removed as
well. However, it is not really related to this CL. WDYT?

[commit-bot: I haz the power, 2017-03-24 19:54:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 19:54:58]

Dry run: This issue passed the CQ dry run.

[brettw, 2017-03-24 20:18:35]

You should be able to implement these out-of-line and not have any bloat
concerns. What made you want to do it in the header? Normally the only reason
these are implemented in headers is for containers that depend on template
parameters.

[jdoerrie, 2017-03-27 11:06:18]

The CQ bit was checked by jdoerrie@chromium.org

[jdoerrie, 2017-03-27 11:06:20]

The CQ bit was unchecked by jdoerrie@chromium.org

[jdoerrie, 2017-03-27 11:06:25]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 11:06:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdoerrie, 2017-03-27 11:19:34]

On 2017/03/24 20:18:35, brettw (plz ping after 24h) wrote:
> You should be able to implement these out-of-line and not have any bloat
> concerns. What made you want to do it in the header? Normally the only reason
> these are implemented in headers is for containers that depend on template
> parameters.

You are right, we should just implement them out of line. I initially decided to
implement them inline because of the proposal doc and how comparison operators
are implemented for base::flat_tree. Your point regarding templates makes a lot
of sense though.

[commit-bot: I haz the power, 2017-03-27 13:40:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 13:40:15]

Dry run: This issue passed the CQ dry run.

[brettw, 2017-03-27 23:13:55]

lgtm

[jdoerrie, 2017-03-28 07:19:05]

On 2017/03/27 23:13:55, brettw (plz ping after 24h) wrote:
> lgtm

Thanks, brettw@! 

A gentle ping for stevenjb@ to review
chrome/browser/ui/webui/options/preferences_browsertest.cc.

[stevenjb, 2017-03-28 15:47:00]

c/b/ui/webui lgtm

[jdoerrie, 2017-03-28 16:07:46]

The CQ bit was checked by jdoerrie@chromium.org

[commit-bot: I haz the power, 2017-03-28 16:08:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 17:52:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490717266345230,
"parent_rev": "6d1e82b93ec0328ec947f387a84fdf2fd42f61f8", "commit_rev":
"5c1cee11c5b383689a81cc5b0c8f65803cef2f33"}

[commit-bot: I haz the power, 2017-03-28 17:52:51]

Description was changed from

==========
Implement comparison operators for base::Value

This change implements comparison operators for base::Value and deprecates the
existing |Equals| methods.

BUG=646133
==========

to

==========
Implement comparison operators for base::Value

This change implements comparison operators for base::Value and deprecates the
existing |Equals| methods.

BUG=646133

Review-Url: https://codereview.chromium.org/2771923005
Cr-Commit-Position: refs/heads/master@{#460162}
Committed:
https://chromium.googlesource.com/chromium/src/+/5c1cee11c5b383689a81cc5b0c8f...
==========

[commit-bot: I haz the power, 2017-03-28 17:52:53]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5c1cee11c5b383689a81cc5b0c8f...