Implement comparison operators for base::Value

chrome/browser/ui/webui/options/preferences_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/preferences_browsertest.h"
 
 #include <stddef.h>
 
 #include <iostream>
 #include <memory>
@@ skipping 49 matching lines @@
 #endif
 
 using testing::AllOf;
 using testing::Mock;
 using testing::Property;
 using testing::Return;
 using testing::_;
 
 namespace base {
 
-// Helper for using EXPECT_EQ() with base::Value.
-bool operator==(const base::Value& first, const base::Value& second) {
-  return first.Equals(&second);
-}
-
 // Helper for pretty-printing the contents of base::Value in case of failures.
 void PrintTo(const base::Value& value, std::ostream* stream) {

[jdoerrie, 2017/03/24 16:33:16]

Given the presence of |std::ostream& operator<<(std::ostream& out, const Value&
value)| that pretty much does the same thing I feel like this can be removed as
well. However, it is not really related to this CL. WDYT?

   std::string json;
   JSONWriter::Write(value, &json);
   *stream << json;
 }
 
 }  // namespace base
 
 // Googlemock matcher for base::Value.
 MATCHER_P(EqualsValue, expected, "") {
   return arg && arg->Equals(expected);
@@ skipping 1015 matching lines @@
                base::Value(3));
   SetProxyPref(chromeos::proxy_cros_settings_parser::kProxySocksPort,
                base::Value(4));
 
   VerifyCurrentProxyServer(
       "http=a.com:1;https=4.3.2.1:2;ftp=c.com:3;socks=socks4://d.com:4",
       onc::ONC_SOURCE_NONE);
 }
 
 #endif