Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2771923003: Add missing headers in WebKit/public to GN (Closed)

Created:
3 years, 9 months ago by wychen
Modified:
3 years, 9 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix all GN missing headers in WebKit/public These were reported by tzik@: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/1kK45mVemBc BUG=661774 Review-Url: https://codereview.chromium.org/2771923003 Cr-Commit-Position: refs/heads/master@{#459369} Committed: https://chromium.googlesource.com/chromium/src/+/c098755ccb6890ee04b345381f07be5224b1e717

Patch Set 1 #

Patch Set 2 : include web/ #

Patch Set 3 : handle mac #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
M content/renderer/text_input_client_observer.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 2 3 20 chunks +40 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (16 generated)
wychen
PTAL
3 years, 9 months ago (2017-03-23 22:28:27 UTC) #2
esprehn
lgtm
3 years, 9 months ago (2017-03-23 22:32:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771923003/40001
3 years, 9 months ago (2017-03-24 00:45:07 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/413883)
3 years, 9 months ago (2017-03-24 01:53:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771923003/40001
3 years, 9 months ago (2017-03-24 02:00:16 UTC) #14
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/public/BUILD.gn: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-03-24 02:57:29 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771923003/60001
3 years, 9 months ago (2017-03-24 03:06:25 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/179142)
3 years, 9 months ago (2017-03-24 04:58:03 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771923003/60001
3 years, 9 months ago (2017-03-24 05:04:10 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 06:05:44 UTC) #26
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c098755ccb6890ee04b345381f07...

Powered by Google App Engine
This is Rietveld 408576698