|
|
Chromium Code Reviews
DescriptionFix all GN missing headers in WebKit/public
These were reported by tzik@:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/1kK45mVemBc
BUG=661774
Review-Url: https://codereview.chromium.org/2771923003
Cr-Commit-Position: refs/heads/master@{#459369}
Committed: https://chromium.googlesource.com/chromium/src/+/c098755ccb6890ee04b345381f07be5224b1e717
Patch Set 1 #Patch Set 2 : include web/ #Patch Set 3 : handle mac #Patch Set 4 : rebase #Messages
Total messages: 26 (16 generated)
wychen@chromium.org changed reviewers: + esprehn@chromium.org
PTAL
Description was changed from ========== Add missing headers in WebKit/public/platform to GN These were reported by tzik@: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/1kK45mVemBc BUG=661774 ========== to ========== Add missing headers in WebKit/public to GN These were reported by tzik@: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/1kK45mVemBc BUG=661774 ==========
The CQ bit was checked by wychen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Description was changed from ========== Add missing headers in WebKit/public to GN These were reported by tzik@: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/1kK45mVemBc BUG=661774 ========== to ========== Fix all GN missing headers in WebKit/public These were reported by tzik@: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/1kK45mVemBc BUG=661774 ==========
The CQ bit was checked by wychen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org Link to the patchset: https://codereview.chromium.org/2771923003/#ps40001 (title: "handle mac")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by wychen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for third_party/WebKit/public/BUILD.gn:
While running git apply --index -p1;
error: patch failed: third_party/WebKit/public/BUILD.gn:89
error: third_party/WebKit/public/BUILD.gn: patch does not apply
Patch: third_party/WebKit/public/BUILD.gn
Index: third_party/WebKit/public/BUILD.gn
diff --git a/third_party/WebKit/public/BUILD.gn
b/third_party/WebKit/public/BUILD.gn
index
ef0e39d70103c1cdeb719e2448253b8e935aeb88..6ee1d59ec31d655420374f2c09a2ecf6e03857b6
100644
--- a/third_party/WebKit/public/BUILD.gn
+++ b/third_party/WebKit/public/BUILD.gn
@@ -89,10 +89,14 @@ if (is_android) {
# and public structures without actually linking against any Blink libraries.
source_set("blink_headers") {
sources = [
+ "platform/BlameContext.h",
"platform/Connector.h",
"platform/FilePathConversion.h",
"platform/InterfaceProvider.h",
+ "platform/InterfaceRegistry.h",
"platform/Platform.h",
+ "platform/PointerProperties.h",
+ "platform/ShapeProperties.h",
"platform/URLConversion.h",
"platform/UserMetricsAction.h",
"platform/WebAddressSpace.h",
@@ -102,14 +106,17 @@ source_set("blink_headers") {
"platform/WebAudioBus.h",
"platform/WebAudioDestinationConsumer.h",
"platform/WebAudioDevice.h",
+ "platform/WebAudioLatencyHint.h",
"platform/WebAudioSourceProvider.h",
"platform/WebAudioSourceProviderClient.h",
"platform/WebBlendMode.h",
"platform/WebBlobData.h",
"platform/WebBlobInfo.h",
"platform/WebBlobRegistry.h",
+ "platform/WebBrowserControlsState.h",
"platform/WebCString.h",
"platform/WebCache.h",
+ "platform/WebCachePolicy.h",
"platform/WebCallbacks.h",
"platform/WebCanvas.h",
"platform/WebCanvasCaptureHandler.h",
@@ -118,6 +125,7 @@ source_set("blink_headers") {
"platform/WebColor.h",
"platform/WebCommon.h",
"platform/WebCompositeAndReadbackAsyncCallback.h",
+ "platform/WebCompositorMutatorClient.h",
"platform/WebCompositorSupport.h",
"platform/WebConnectionType.h",
"platform/WebContentDecryptionModule.h",
@@ -127,6 +135,8 @@ source_set("blink_headers") {
"platform/WebContentDecryptionModuleSession.h",
"platform/WebContentLayer.h",
"platform/WebContentLayerClient.h",
+ "platform/WebContentSecurityPolicy.h",
+ "platform/WebContentSecurityPolicyStruct.h",
"platform/WebContentSettingCallbacks.h",
"platform/WebCookieJar.h",
"platform/WebCredential.h",
@@ -145,8 +155,10 @@ source_set("blink_headers") {
"platform/WebDeviceLightListener.h",
"platform/WebDisplayItemList.h",
"platform/WebDisplayMode.h",
+ "platform/WebDistillability.h",
"platform/WebDocumentSubresourceFilter.h",
"platform/WebDoublePoint.h",
+ "platform/WebDoubleSize.h",
"platform/WebDragData.h",
"platform/WebDragOperation.h",
"platform/WebEditingCommandType.h",
@@ -155,9 +167,11 @@ source_set("blink_headers") {
"platform/WebEncryptedMediaKeyInformation.h",
"platform/WebEncryptedMediaRequest.h",
"platform/WebEncryptedMediaTypes.h",
+ "platform/WebEventListenerProperties.h",
"platform/WebExternalBitmap.h",
"platform/WebExternalTextureLayer.h",
"platform/WebFallbackThemeEngine.h",
+ "platform/WebFeaturePolicy.h",
"platform/WebFederatedCredential.h",
"platform/WebFileError.h",
"platform/WebFileInfo.h",
@@ -190,6 +204,7 @@ source_set("blink_headers") {
"platform/WebHistoryScrollRestorationType.h",
"platform/WebIconSizesParser.h",
"platform/WebImage.h",
+ "platform/WebImageCaptureFrameGrabber.h",
"platform/WebImageGenerator.h",
"platform/WebImageLayer.h",
"platform/WebInbandTextTrack.h",
@@ -204,6 +219,7 @@ source_set("blink_headers") {
"platform/WebLayerStickyPositionConstraint.h",
"platform/WebLayerTreeView.h",
"platform/WebLayoutAndPaintAsyncCallback.h",
+ "platform/WebLoadingBehaviorFlag.h",
"platform/WebLocalizedString.h",
"platform/WebMediaConstraints.h",
"platform/WebMediaDeviceInfo.h",
@@ -211,6 +227,7 @@ source_set("blink_headers") {
"platform/WebMediaKeySystemMediaCapability.h",
"platform/WebMediaPlayer.h",
"platform/WebMediaPlayerClient.h",
+ "platform/WebMediaPlayerEncryptedMediaClient.h",
"platform/WebMediaPlayerSource.h",
"platform/WebMediaRecorderHandler.h",
"platform/WebMediaRecorderHandlerClient.h",
@@ -229,6 +246,7 @@ source_set("blink_headers") {
"platform/WebMixedContent.h",
"platform/WebMixedContentContextType.h",
"platform/WebMockClipboard.h",
+ "platform/WebMouseEvent.h",
"platform/WebMouseWheelEvent.h",
"platform/WebNativeScrollBehavior.h",
"platform/WebNavigationHintType.h",
@@ -241,12 +259,14 @@ source_set("blink_headers") {
"platform/WebPlatformEventType.h",
"platform/WebPluginListBuilder.h",
"platform/WebPoint.h",
+ "platform/WebPointerProperties.h",
"platform/WebPrerender.h",
"platform/WebPrerenderingSupport.h",
"platform/WebPrescientNetworking.h",
"platform/WebPrivateOwnPtr.h",
"platform/WebPrivatePtr.h",
"platform/WebPublicSuffixList.h",
+ "platform/WebRTCAnswerOptions.h",
"platform/WebRTCCertificate.h",
"platform/WebRTCCertificateGenerator.h",
"platform/WebRTCConfiguration.h",
@@ -306,17 +326,22 @@ source_set("blink_headers") {
"platform/WebThreadSafeData.h",
"platform/WebTimeRange.h",
"platform/WebTopControlsState.h",
+ "platform/WebTouchEvent.h",
"platform/WebTouchPoint.h",
"platform/WebTraceLocation.h",
+ "platform/WebTrialTokenValidator.h",
"platform/WebURL.h",
"platform/WebURLError.h",
"platform/WebURLLoadTiming.h",
"platform/WebURLLoader.h",
"platform/WebURLLoaderClient.h",
"platform/WebURLLoaderMockFactory.h",
+ "platform/WebURLLoaderTestDelegate.h",
"platform/WebURLRequest.h",
"platform/WebURLResponse.h",
"platform/WebVector.h",
+ "platform/WebViewScheduler.h",
+ "platform/WebViewportStyle.h",
"platform/callback/WebClosure.h",
"platform/linux/WebFallbackFont.h",
"platform/linux/WebFontRenderStyle.h",
@@ -338,8 +363,15 @@ source_set("blink_headers") {
"platform/modules/indexeddb/WebIDBObservation.h",
"platform/modules/indexeddb/WebIDBTypes.h",
"platform/modules/indexeddb/WebIDBValue.h",
+ "platform/modules/installedapp/WebRelatedApplication.h",
"platform/modules/installedapp/WebRelatedAppsFetcher.h",
+ "platform/modules/media_capabilities/WebAudioConfiguration.h",
+ "platform/modules/media_capabilities/WebMediaCapabilitiesClient.h",
+ "platform/modules/media_capabilities/WebMediaConfiguration.h",
+ "platform/modules/media_capabilities/WebMediaDecodingAbility.h",
+ "platform/modules/media_capabilities/WebVideoConfiguration.h",
"platform/modules/notifications/WebNotificationAction.h",
+ "platform/modules/notifications/WebNotificationConstants.h",
"platform/modules/notifications/WebNotificationData.h",
"platform/modules/notifications/WebNotificationDelegate.h",
"platform/modules/notifications/WebNotificationManager.h",
@@ -404,6 +436,7 @@ source_set("blink_headers") {
"platform/modules/websockets/WebSocketHandshakeRequestInfo.h",
"platform/modules/websockets/WebSocketHandshakeResponseInfo.h",
"platform/scheduler/base/task_queue.h",
+ "platform/scheduler/base/task_time_observer.h",
"platform/scheduler/child/child_scheduler.h",
"platform/scheduler/child/compositor_worker_scheduler.h",
"platform/scheduler/child/single_thread_idle_task_runner.h",
@@ -422,10 +455,13 @@ source_set("blink_headers") {
"web/WebArrayBuffer.h",
"web/WebArrayBufferConverter.h",
"web/WebArrayBufferView.h",
+ "web/WebAssociatedURLLoader.h",
+ "web/WebAssociatedURLLoaderClient.h",
"web/WebAssociatedURLLoaderOptions.h",
"web/WebAutofillClient.h",
"web/WebBlob.h",
"web/WebCSSParser.h",
+ "web/WebClientRedirectPolicy.h",
"web/WebColorChooser.h",
"web/WebColorChooserClient.h",
"web/WebColorSuggestion.h",
@@ -473,6 +509,7 @@ source_set("blink_headers") {
"web/WebFrameLoadType.h",
"web/WebFrameOwnerProperties.h",
"web/WebFrameSerializer.h",
+ "web/WebFrameSerializerCacheControlPolicy.h",
"web/WebFrameSerializerClient.h",
"web/WebFrameWidget.h",
"web/WebHeap.h",
@@ -503,6 +540,7 @@ source_set("blink_headers") {
"web/WebNavigatorContentUtilsClient.h",
"web/WebNode.h",
"web/WebOptionElement.h",
+ "web/WebPageImportanceSignals.h",
"web/WebPagePopup.h",
"web/WebPepperSocket.h",
"web/WebPepperSocketClient.h",
@@ -544,6 +582,7 @@ source_set("blink_headers") {
"web/WebSharedWorkerCreationContextType.h",
"web/WebSharedWorkerCreationErrors.h",
"web/WebSharedWorkerRepositoryClient.h",
+ "web/WebSourceLocation.h",
"web/WebSpeechGrammar.h",
"web/WebSpeechRecognitionHandle.h",
"web/WebSpeechRecognitionParams.h",
@@ -558,6 +597,7 @@ source_set("blink_headers") {
"web/WebTextCheckingResult.h",
"web/WebTextDecorationType.h",
"web/WebTextDirection.h",
+ "web/WebTextInputType.h",
"web/WebTouchAction.h",
"web/WebTreeScopeType.h",
"web/WebUserGestureIndicator.h",
@@ -573,6 +613,7 @@ source_set("blink_headers") {
"web/linux/WebFontRendering.h",
"web/mac/WebScrollbarTheme.h",
"web/mac/WebSubstringUtil.h",
+ "web/mac/WebSubstringUtil.h",
"web/modules/serviceworker/WebServiceWorkerContextClient.h",
"web/modules/serviceworker/WebServiceWorkerContextProxy.h",
"web/win/WebFontRendering.h",
The CQ bit was checked by wychen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org Link to the patchset: https://codereview.chromium.org/2771923003/#ps60001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by wychen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490331831535350,
"parent_rev": "bc36f7dec127945db4d5978d2793b671863f7dd7", "commit_rev":
"c098755ccb6890ee04b345381f07be5224b1e717"}
Message was sent while issue was closed.
Description was changed from ========== Fix all GN missing headers in WebKit/public These were reported by tzik@: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/1kK45mVemBc BUG=661774 ========== to ========== Fix all GN missing headers in WebKit/public These were reported by tzik@: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/1kK45mVemBc BUG=661774 Review-Url: https://codereview.chromium.org/2771923003 Cr-Commit-Position: refs/heads/master@{#459369} Committed: https://chromium.googlesource.com/chromium/src/+/c098755ccb6890ee04b345381f07... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/c098755ccb6890ee04b345381f07... |
