Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2771723002: Pref service: Merge PrefStoreConnector interfaces. (Closed)

Created:
3 years, 9 months ago by Sam McNally
Modified:
3 years, 9 months ago
Reviewers:
Martin Barbella, tibell
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pref service: Merge PrefStoreConnector interfaces. Previously, there were two connectors: one for persistent prefs and another for read-only pref stores. This merges the two connectors into a single connector and merges responsibility for queuing persistent pref store connect requests from PersistentPrefStoreImpl into PrefStoreManagerImpl (where queuing is already implemented for read-only pref stores). BUG=654988 Review-Url: https://codereview.chromium.org/2771723002 Cr-Commit-Position: refs/heads/master@{#459680} Committed: https://chromium.googlesource.com/chromium/src/+/6a6b14251ec38a7dccc0acae9a548fb181291e4d

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -386 lines) Patch
M services/preferences/manifest.json View 1 chunk +1 line, -2 lines 0 comments Download
M services/preferences/persistent_pref_store_factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M services/preferences/persistent_pref_store_factory.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M services/preferences/persistent_pref_store_impl.h View 1 2 chunks +10 lines, -8 lines 0 comments Download
M services/preferences/persistent_pref_store_impl.cc View 1 3 chunks +25 lines, -33 lines 0 comments Download
M services/preferences/persistent_pref_store_impl_unittest.cc View 1 16 chunks +39 lines, -141 lines 0 comments Download
M services/preferences/pref_service_factory_unittest.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M services/preferences/pref_store_manager_impl.h View 4 chunks +6 lines, -14 lines 0 comments Download
M services/preferences/pref_store_manager_impl.cc View 1 10 chunks +61 lines, -39 lines 0 comments Download
M services/preferences/public/cpp/persistent_pref_store_client.h View 1 3 chunks +8 lines, -8 lines 0 comments Download
M services/preferences/public/cpp/persistent_pref_store_client.cc View 1 3 chunks +32 lines, -22 lines 0 comments Download
M services/preferences/public/cpp/pref_service_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M services/preferences/public/cpp/pref_service_factory.cc View 3 chunks +23 lines, -71 lines 0 comments Download
M services/preferences/public/cpp/preferences.typemap View 1 chunk +1 line, -1 line 0 comments Download
M services/preferences/public/cpp/preferences_struct_traits.h View 1 chunk +3 lines, -3 lines 0 comments Download
M services/preferences/public/cpp/preferences_struct_traits.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/preferences/public/cpp/tests/pref_store_client_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M services/preferences/public/interfaces/preferences.mojom View 3 chunks +24 lines, -30 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 43 (37 generated)
Sam McNally
3 years, 9 months ago (2017-03-23 00:21:47 UTC) #8
tibell
lgtm https://codereview.chromium.org/2771723002/diff/40001/services/preferences/persistent_pref_store_impl.cc File services/preferences/persistent_pref_store_impl.cc (right): https://codereview.chromium.org/2771723002/diff/40001/services/preferences/persistent_pref_store_impl.cc#newcode90 services/preferences/persistent_pref_store_impl.cc:90: mojom::PersistentPrefStoreConnectionPtr PersistentPrefStoreImpl::Connect() { Perhaps call it CreateConnection. https://codereview.chromium.org/2771723002/diff/40001/services/preferences/persistent_pref_store_impl.cc#newcode93 ...
3 years, 9 months ago (2017-03-23 02:22:04 UTC) #12
Sam McNally
+mbarbella for mojom, traits, typemap and manifest. https://codereview.chromium.org/2771723002/diff/40001/services/preferences/persistent_pref_store_impl.cc File services/preferences/persistent_pref_store_impl.cc (right): https://codereview.chromium.org/2771723002/diff/40001/services/preferences/persistent_pref_store_impl.cc#newcode90 services/preferences/persistent_pref_store_impl.cc:90: mojom::PersistentPrefStoreConnectionPtr PersistentPrefStoreImpl::Connect() ...
3 years, 9 months ago (2017-03-23 02:36:27 UTC) #21
Martin Barbella
Sorry for the delay. LGTM.
3 years, 9 months ago (2017-03-24 16:29:40 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771723002/100001
3 years, 9 months ago (2017-03-26 23:01:21 UTC) #40
commit-bot: I haz the power
3 years, 9 months ago (2017-03-26 23:07:03 UTC) #43
Message was sent while issue was closed.
Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/6a6b14251ec38a7dccc0acae9a54...

Powered by Google App Engine
This is Rietveld 408576698