Move PrefStoreManagerImpl into //services/preferences.

Move PrefStoreManagerImpl into //services/preferences.

PrefStoreManagerImpl is an implementation detail so it shouldn't be in
public.

BUG=654988
Review-Url: https://codereview.chromium.org/2759413002
Cr-Commit-Position: refs/heads/master@{#458967}
Committed: https://chromium.googlesource.com/chromium/src/+/939cdb5314dcd4a523196c849a5c93f53c5b5286

[Sam McNally, 2017-03-21 03:18:11]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 03:18:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-03-21 04:56:41]

sammc@chromium.org changed reviewers:
+ mlerman@chromium.org, tibell@chromium.org

[Sam McNally, 2017-03-21 04:56:42]

+tibell for everything

+mlerman for chrome/browser/profiles/profile_impl.cc

[commit-bot: I haz the power, 2017-03-21 05:17:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 05:17:44]

Dry run: This issue passed the CQ dry run.

[Mike Lerman, 2017-03-21 13:32:40]

https://codereview.chromium.org/2759413002/diff/1/chrome/browser/profiles/pro...
File chrome/browser/profiles/profile_impl.cc (right):

https://codereview.chromium.org/2759413002/diff/1/chrome/browser/profiles/pro...
chrome/browser/profiles/profile_impl.cc:1067: content::ServiceInfo info;
You're iterating on this within the Profiles directory a lot...

Would it be worthwhile to create a method within services/preferences that
creates the content::ServiceInfo object, and then this method is just
responsible for inserting it into StaticServiceMap?

Or even just passing the StaticServiceMap into the services/preferences code,
and having it insert its own object?

[tibell, 2017-03-21 22:06:33]

lgtm

https://codereview.chromium.org/2759413002/diff/1/services/preferences/pref_s...
File services/preferences/pref_store_manager_impl.h (right):

https://codereview.chromium.org/2759413002/diff/1/services/preferences/pref_s...
services/preferences/pref_store_manager_impl.h:44: using PrefStoreTypes =
std::set<PrefValueStore::PrefStoreType>;
Delete this as well?

[Sam McNally, 2017-03-21 22:50:00]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[Sam McNally, 2017-03-21 22:50:23]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-03-21 22:50:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-03-21 23:10:51]

https://codereview.chromium.org/2759413002/diff/1/chrome/browser/profiles/pro...
File chrome/browser/profiles/profile_impl.cc (right):

https://codereview.chromium.org/2759413002/diff/1/chrome/browser/profiles/pro...
chrome/browser/profiles/profile_impl.cc:1067: content::ServiceInfo info;
On 2017/03/21 13:32:40, Mike Lerman wrote:
> You're iterating on this within the Profiles directory a lot...
> 
> Would it be worthwhile to create a method within services/preferences that
> creates the content::ServiceInfo object, and then this method is just
> responsible for inserting it into StaticServiceMap?
> 
> Or even just passing the StaticServiceMap into the services/preferences code,
> and having it insert its own object?

Unfortunately, those aren't viable options due to layering: //services can't
depend on content; ServiceInfo and StaticServiceMap are both provided by
content. We also need something to inject the blocking pool.

https://codereview.chromium.org/2759413002/diff/1/services/preferences/pref_s...
File services/preferences/pref_store_manager_impl.h (right):

https://codereview.chromium.org/2759413002/diff/1/services/preferences/pref_s...
services/preferences/pref_store_manager_impl.h:44: using PrefStoreTypes =
std::set<PrefValueStore::PrefStoreType>;
On 2017/03/21 22:06:33, tibell wrote:
> Delete this as well?

Done.

[commit-bot: I haz the power, 2017-03-21 23:11:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 23:11:40]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Mike Lerman, 2017-03-22 13:27:57]

profiles LGTM

[Sam McNally, 2017-03-22 23:37:46]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2017-03-22 23:37:47]

The patchset sent to the CQ was uploaded after l-g-t-m from tibell@chromium.org,
mlerman@chromium.org
Link to the patchset: https://codereview.chromium.org/2759413002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-22 23:38:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-03-22 23:50:06]

The CQ bit was unchecked by sammc@chromium.org

[Sam McNally, 2017-03-22 23:56:35]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2017-03-22 23:56:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlerman@chromium.org, tibell@chromium.org
Link to the patchset: https://codereview.chromium.org/2759413002/#ps80001
(title: "Update newly-added test.")

[commit-bot: I haz the power, 2017-03-22 23:57:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 01:21:17]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490226995183310,
"parent_rev": "b486c36c34f1b6370d65cacc4919c429f65c1dc0", "commit_rev":
"939cdb5314dcd4a523196c849a5c93f53c5b5286"}

[commit-bot: I haz the power, 2017-03-23 01:22:28]

Description was changed from

==========
Move PrefStoreManagerImpl into //services/preferences.

PrefStoreManagerImpl is an implementation detail so it shouldn't be in
public.

BUG=654988
==========

to

==========
Move PrefStoreManagerImpl into //services/preferences.

PrefStoreManagerImpl is an implementation detail so it shouldn't be in
public.

BUG=654988

Review-Url: https://codereview.chromium.org/2759413002
Cr-Commit-Position: refs/heads/master@{#458967}
Committed:
https://chromium.googlesource.com/chromium/src/+/939cdb5314dcd4a523196c849a5c...
==========

[commit-bot: I haz the power, 2017-03-23 01:22:29]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/939cdb5314dcd4a523196c849a5c...