Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2771703003: Revert of [heap] Simplify clearing of normalized map caches. (Closed)

Created:
3 years, 9 months ago by ulan
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Simplify clearing of normalized map caches. (patchset #1 id:1 of https://codereview.chromium.org/2745183002/ ) Reason for revert: https://bugs.chromium.org/p/v8/issues/detail?id=6135 Original issue's description: > [heap] Simplify clearing of normalized map caches. > > Currently the incremental marking visitor treats elements of normalized > map caches weakly by coloring the caches grey without pusing to marking > deque. > > The mark-compact prologue then clears all normalized map caches. > > We can achieve similar effect by just clearing the caches in the marking > visitor. > > BUG=chromium:694255 > > Review-Url: https://codereview.chromium.org/2745183002 > Cr-Commit-Position: refs/heads/master@{#43941} > Committed: https://chromium.googlesource.com/v8/v8/+/3d68306c71b17ebcb306b4e2ed8cae110c52229c TBR=hpayer@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2771703003 Cr-Commit-Position: refs/heads/master@{#44056} Committed: https://chromium.googlesource.com/v8/v8/+/1a7a6057504cf57ee31a8513309898ca2cb1b7dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -7 lines) Patch
M src/heap/heap.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M src/heap/incremental-marking.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
ulan
Created Revert of [heap] Simplify clearing of normalized map caches.
3 years, 9 months ago (2017-03-23 08:59:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771703003/1
3 years, 9 months ago (2017-03-23 08:59:37 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 09:28:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1a7a6057504cf57ee31a8513309898ca2cb...

Powered by Google App Engine
This is Rietveld 408576698