Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2745183002: [heap] Simplify clearing of normalized map caches. (Closed)

Created:
3 years, 9 months ago by ulan
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Simplify clearing of normalized map caches. Currently the incremental marking visitor treats elements of normalized map caches weakly by coloring the caches grey without pusing to marking deque. The mark-compact prologue then clears all normalized map caches. We can achieve similar effect by just clearing the caches in the marking visitor. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2745183002 Cr-Commit-Position: refs/heads/master@{#43941} Committed: https://chromium.googlesource.com/v8/v8/+/3d68306c71b17ebcb306b4e2ed8cae110c52229c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -44 lines) Patch
M src/heap/heap.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +0 lines, -21 lines 1 comment Download
M src/heap/incremental-marking.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
ulan
Hannes, ptal. Toon, fyi. https://codereview.chromium.org/2745183002/diff/1/src/heap/heap.cc File src/heap/heap.cc (left): https://codereview.chromium.org/2745183002/diff/1/src/heap/heap.cc#oldcode1253 src/heap/heap.cc:1253: if (isolate_->bootstrapper()->IsActive() && I don't ...
3 years, 9 months ago (2017-03-13 14:36:01 UTC) #2
Hannes Payer (out of office)
lgtm
3 years, 9 months ago (2017-03-20 14:18:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745183002/1
3 years, 9 months ago (2017-03-20 14:29:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/3d68306c71b17ebcb306b4e2ed8cae110c52229c
3 years, 9 months ago (2017-03-20 14:55:56 UTC) #8
ulan
3 years, 9 months ago (2017-03-23 08:59:30 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2771703003/ by ulan@chromium.org.

The reason for reverting is:
https://bugs.chromium.org/p/v8/issues/detail?id=6135.

Powered by Google App Engine
This is Rietveld 408576698