Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2771663004:
Relax the eplison to check snapping (Closed)
DescriptionRelax the eplison to check snapping
BUG=637172
Review-Url: https://codereview.chromium.org/2771663004
Cr-Commit-Position: refs/heads/master@{#459237}
Committed: https://chromium.googlesource.com/chromium/src/+/31fb61e4a57da0fcc54a87bda416a8d7c8344de1
Patch Set 1 #
Total comments: 2
Messages
Total messages: 14 (6 generated)
Description was changed from ========== Relax the eplison to check snapping BUG=637172 ========== to ========== Relax the eplison to check snapping BUG=637172 ==========
oshima@chromium.org changed reviewers: + piman@chromium.org
lgtm
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490301432249510, "parent_rev":
"4acc1b9ec5c57d349f0ebb9b1f77bd2bc81b1064", "commit_rev":
"31fb61e4a57da0fcc54a87bda416a8d7c8344de1"}
Message was sent while issue was closed.
Description was changed from ========== Relax the eplison to check snapping BUG=637172 ========== to ========== Relax the eplison to check snapping BUG=637172 Review-Url: https://codereview.chromium.org/2771663004 Cr-Commit-Position: refs/heads/master@{#459237} Committed: https://chromium.googlesource.com/chromium/src/+/31fb61e4a57da0fcc54a87bda416... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/31fb61e4a57da0fcc54a87bda416...
Message was sent while issue was closed.
servolk@chromium.org changed reviewers: + servolk@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2771663004/diff/1/ui/compositor/dip_util.cc File ui/compositor/dip_util.cc (right): https://codereview.chromium.org/2771663004/diff/1/ui/compositor/dip_util.cc#n... ui/compositor/dip_util.cc:69: const float kEplison = 0.0002f; Nit: fix the typo while you are at it kEplison -> kEpsilon
Message was sent while issue was closed.
https://codereview.chromium.org/2771663004/diff/1/ui/compositor/dip_util.cc File ui/compositor/dip_util.cc (right): https://codereview.chromium.org/2771663004/diff/1/ui/compositor/dip_util.cc#n... ui/compositor/dip_util.cc:69: const float kEplison = 0.0002f; On 2017/03/23 21:49:00, servolk wrote: > Nit: fix the typo while you are at it kEplison -> kEpsilon Also, I'm pretty sure 0.0002f is not enough. I have been still getting DCHECKs when I tried that locally. 0.0005f seems to work fine. But it's still not clear to me how this value was calculated. Do you mind explaining why you chose 0.0002f?
Message was sent while issue was closed.
On 2017/03/23 21:50:24, servolk wrote: > https://codereview.chromium.org/2771663004/diff/1/ui/compositor/dip_util.cc > File ui/compositor/dip_util.cc (right): > > https://codereview.chromium.org/2771663004/diff/1/ui/compositor/dip_util.cc#n... > ui/compositor/dip_util.cc:69: const float kEplison = 0.0002f; > On 2017/03/23 21:49:00, servolk wrote: > > Nit: fix the typo while you are at it kEplison -> kEpsilon > > Also, I'm pretty sure 0.0002f is not enough. I have been still getting DCHECKs > when I tried that locally. 0.0005f seems to work fine. But it's still not clear > to me how this value was calculated. Do you mind explaining why you chose > 0.0002f? Ping. This is still happening to me on my Linux workstation with 2560x1600 screen resolution: [95503:95503:0331/114850.167898:FATAL:dip_util.cc(71)] Check failed: diff < kEplison (0.000244141 vs. 0.0002)
Message was sent while issue was closed.
On 2017/03/31 18:50:29, servolk wrote: > On 2017/03/23 21:50:24, servolk wrote: > > https://codereview.chromium.org/2771663004/diff/1/ui/compositor/dip_util.cc > > File ui/compositor/dip_util.cc (right): > > > > > https://codereview.chromium.org/2771663004/diff/1/ui/compositor/dip_util.cc#n... > > ui/compositor/dip_util.cc:69: const float kEplison = 0.0002f; > > On 2017/03/23 21:49:00, servolk wrote: > > > Nit: fix the typo while you are at it kEplison -> kEpsilon > > > > Also, I'm pretty sure 0.0002f is not enough. I have been still getting DCHECKs > > when I tried that locally. 0.0005f seems to work fine. But it's still not > clear > > to me how this value was calculated. Do you mind explaining why you chose > > 0.0002f? > > Ping. This is still happening to me on my Linux workstation with 2560x1600 > screen resolution: > [95503:95503:0331/114850.167898:FATAL:dip_util.cc(71)] Check failed: diff < > kEplison (0.000244141 vs. 0.0002) Ping. Still happening here, whenever I open a new tab. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
