Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2771443002: Revert of WebUI: Disable all JS tests in MSAN, ASAN, and TSAN bots. (Closed)

Created:
3 years, 9 months ago by Lei Zhang
Modified:
3 years, 9 months ago
Reviewers:
Dan Beam, dpapad
CC:
chromium-reviews, michaelpg, stevenjb
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of WebUI: Disable all JS tests in MSAN, ASAN, and TSAN bots. (patchset #3 id:80001 of https://codereview.chromium.org/2760693002/ ) Reason for revert: May be causing isolate_tests failures. Speculative revert for https://crbug.com/703830 Original issue's description: > WebUI: Disable all JS tests in MSAN, ASAN, and TSAN bots. > > There is not a lot of benefit of running WebUI JS tests on *SAN bots. > Previously at crrev.com/2690303003, all MD Settings tests were disabled > for ASAN bots. This CL does the same for MSAN, TSAN and for all WebUI tests. > > BUG=None > > Review-Url: https://codereview.chromium.org/2760693002 > Cr-Commit-Position: refs/heads/master@{#458479} > Committed: https://chromium.googlesource.com/chromium/src/+/225850541ea9b36ecb151863f54c3a4265af085f TBR=dbeam@chromium.org,dpapad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.chromium.org/2771443002 Cr-Commit-Position: refs/heads/master@{#458608} Committed: https://chromium.googlesource.com/chromium/src/+/ff36751cb66d5c94754164ec09698dc2ac1f01c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -207 lines) Patch
M chrome/test/BUILD.gn View 9 chunks +178 lines, -182 lines 0 comments Download
M chrome/test/data/webui/md_history/md_history_browsertest.js View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/data/webui/sandboxstatus_browsertest.js View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/data/webui/settings/advanced_page_browsertest.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/data/webui/settings/basic_page_browsertest.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/data/webui/settings/easy_unlock_browsertest_chromeos.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/data/webui/settings/languages_page_browsertest.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/data/webui/settings/settings_ui_browsertest.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Lei Zhang
Created Revert of WebUI: Disable all JS tests in MSAN, ASAN, and TSAN bots.
3 years, 9 months ago (2017-03-22 00:19:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771443002/1
3 years, 9 months ago (2017-03-22 00:19:48 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 00:22:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ff36751cb66d5c94754164ec0969...

Powered by Google App Engine
This is Rietveld 408576698