Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 2771413006: Revert of [DevTools] Migrate SoftContextMenu to use GlassPane (Closed)

Created:
3 years, 8 months ago by alph
Modified:
3 years, 8 months ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Migrate SoftContextMenu to use GlassPane (patchset #2 id:20001 of https://codereview.chromium.org/2778623002/ ) Reason for revert: Broke DevTools settings Original issue's description: > [DevTools] Migrate SoftContextMenu to use GlassPane > > Let the GlassPane handle all the tricky details about positioning. > > BUG=none TBR=lushnikov@chromium.org,dgozman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=none Review-Url: https://codereview.chromium.org/2771413006 Cr-Commit-Position: refs/heads/master@{#460228} Committed: https://chromium.googlesource.com/chromium/src/+/ac4d06a47287a0303deac7879251b476d0de3b46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -64 lines) Patch
M third_party/WebKit/Source/devtools/front_end/inline_editor/SwatchPopoverHelper.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ContextMenu.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js View 8 chunks +11 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Popover.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js View 6 chunks +98 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/softContextMenu.css View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
alph
Created Revert of [DevTools] Migrate SoftContextMenu to use GlassPane
3 years, 8 months ago (2017-03-28 21:27:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771413006/1
3 years, 8 months ago (2017-03-28 21:27:11 UTC) #3
commit-bot: I haz the power
Exceeded global retry quota
3 years, 8 months ago (2017-03-28 21:39:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771413006/1
3 years, 8 months ago (2017-03-28 22:09:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ac4d06a47287a0303deac7879251b476d0de3b46
3 years, 8 months ago (2017-03-28 22:55:22 UTC) #10
dgozman
3 years, 8 months ago (2017-03-30 20:47:57 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2790613003/ by dgozman@chromium.org.

The reason for reverting is: The regression was fixed in
https://codereview.chromium.org/2776263006/.

Powered by Google App Engine
This is Rietveld 408576698