Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2778623002: [DevTools] Migrate SoftContextMenu to use GlassPane (Closed)

Created:
3 years, 9 months ago by dgozman
Modified:
3 years, 8 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Migrate SoftContextMenu to use GlassPane Let the GlassPane handle all the tricky details about positioning. BUG=none

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -111 lines) Patch
M third_party/WebKit/Source/devtools/front_end/inline_editor/SwatchPopoverHelper.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ContextMenu.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js View 1 8 chunks +20 lines, -10 lines 2 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Popover.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js View 7 chunks +35 lines, -95 lines 2 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/softContextMenu.css View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
dgozman
Could you please take a look?
3 years, 9 months ago (2017-03-25 18:47:27 UTC) #2
lushnikov
lgtm https://codereview.chromium.org/2778623002/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js File third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js (right): https://codereview.chromium.org/2778623002/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js#newcode126 third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js:126: document.body.addEventListener('click', this._onMouseDownBound, true); is this change to better ...
3 years, 9 months ago (2017-03-27 18:08:33 UTC) #11
dgozman
Thanks for review! https://codereview.chromium.org/2778623002/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js File third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js (right): https://codereview.chromium.org/2778623002/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js#newcode126 third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js:126: document.body.addEventListener('click', this._onMouseDownBound, true); On 2017/03/27 18:08:33, ...
3 years, 8 months ago (2017-03-27 23:08:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778623002/20001
3 years, 8 months ago (2017-03-27 23:09:06 UTC) #14
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 8 months ago (2017-03-28 00:38:33 UTC) #17
dgozman
On 2017/03/28 00:38:33, commit-bot: I haz the power wrote: > Prior attempt to commit was ...
3 years, 8 months ago (2017-03-28 01:11:36 UTC) #18
alph
3 years, 8 months ago (2017-03-28 21:27:04 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2771413006/ by alph@chromium.org.

The reason for reverting is: Broke DevTools settings.

Powered by Google App Engine
This is Rietveld 408576698