Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2771373003: Add most missing blink files to .gn files (Closed)

Created:
3 years, 9 months ago by Nico
Modified:
3 years, 9 months ago
Reviewers:
haraken, tzik
CC:
chromium-reviews, shans, szager+layoutwatch_chromium.org, viettrungluu+watch_chromium.org, dshwang, eae+blinkwatch, fs, dcheng, apavlov+blink_chromium.org, mcasas+geolocation_chromium.org, kinuko+watch, kouhei+svg_chromium.org, blink-reviews-wtf_chromium.org, rwlbuis, darin (slow to review), caseq+blink_chromium.org, krit, Mads Ager (chromium), mvanouwerkerk+watch_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, abarth-chromium, blink-reviews-dom_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, blink-reviews, gyuyoung2, pdr+svgwatchlist_chromium.org, blink-reviews-api_chromium.org, Eric Willigers, yzshen+watch_chromium.org, rjwright, blink-reviews-style_chromium.org, zoltan1, qsr+mojo_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-layout_chromium.org, sof, lushnikov+blink_chromium.org, loading-reviews_chromium.org, tommyw+watchlist_chromium.org, timvolodine, darktears, Nate Chapin, Stephen Chennney, tyoshino+watch_chromium.org, mlamouri+watch-blink_chromium.org, blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, fmalita+watch_chromium.org, pfeldman+blink_chromium.org, Aaron Boodman, oilpan-reviews, blink-reviews-frames_chromium.org, Mikhail, kouhei+heap_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add most missing blink files to .gn files I copied the list of missing files to a txt file and ran this script: import os, re, subprocess edits = {} for filename in open('headers.txt'): filename = filename.strip() dirname = os.path.dirname(filename) while not os.path.exists(os.path.join(dirname, 'BUILD.gn')): dirname = os.path.dirname(dirname) rel = filename[len(dirname) + 1:] gnfile = os.path.join(dirname, 'BUILD.gn') #print gnfile, rel lines = open(gnfile).read().splitlines() index = next( (i for i, l in enumerate(lines) if ' sources = [' in l), -1) if index == -1: continue lines.insert(index + 1, '"%s",' % rel) open(gnfile, 'w').write('\n'.join(lines)) Then I ran `git cl format` to re-sort source lists. I manually fixed up third_party/WebKit/Source/platform/BUILD.gn, third_party/WebKit/public/BUILD.gn, third_party/WebKit/Source/platform/BUILD.gn, where this simple heuristic hadn't worked well. I reverted changes to third_party/WebKit/Source/platform/mojo/BUILD.gn because I don't understand that directory. BUG=661774 NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2771373003 Cr-Commit-Position: refs/heads/master@{#459673} Committed: https://chromium.googlesource.com/chromium/src/+/71d33c3169cf175d2d367834907b86c4023c0496

Patch Set 1 #

Patch Set 2 : fixup #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -1 line) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/BUILD.gn View 4 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/BUILD.gn View 4 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/BUILD.gn View 8 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/BUILD.gn View 5 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/BUILD.gn View 8 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/BUILD.gn View 4 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/BUILD.gn View 6 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/crypto/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/device_light/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/nfc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 2 3 9 chunks +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/BUILD.gn View 4 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 41 (31 generated)
Nico
3 years, 9 months ago (2017-03-26 02:59:06 UTC) #17
haraken
LGTM
3 years, 9 months ago (2017-03-26 03:21:44 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771373003/60001
3 years, 9 months ago (2017-03-26 03:23:29 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/391474)
3 years, 9 months ago (2017-03-26 04:03:04 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771373003/60001
3 years, 9 months ago (2017-03-26 04:08:05 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/8131)
3 years, 9 months ago (2017-03-26 04:46:28 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771373003/60001
3 years, 9 months ago (2017-03-26 04:50:13 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771373003/60001
3 years, 9 months ago (2017-03-26 04:54:13 UTC) #37
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/71d33c3169cf175d2d367834907b86c4023c0496
3 years, 9 months ago (2017-03-26 05:00:12 UTC) #40
tzik
3 years, 9 months ago (2017-03-27 01:54:57 UTC) #41
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698