Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2771353002: Don't force the download notifier to unbind (Closed)

Created:
3 years, 9 months ago by David Trainor- moved to gerrit
Modified:
3 years, 8 months ago
Reviewers:
qinmin
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't force the download notifier to unbind The DownloadNotificationService tells the SystemDownloadNotifier to unbind from it when it has no notifications to show and wants to shut itself down. This isn't needed because the SystemDownloadNotifier will unbind when it is a safe time for the service to die. This patch removes the Observer method that tells the SystemDownloadNotifier to unbind itself. BUG=703212 Review-Url: https://codereview.chromium.org/2771353002 Cr-Commit-Position: refs/heads/master@{#460641} Committed: https://chromium.googlesource.com/chromium/src/+/008b3fe04b6cefb33e44ebb30c4a2fc5881d6d40

Patch Set 1 #

Patch Set 2 : Tested and cleaned up #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -20 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 1 2 2 chunks +5 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java View 1 2 2 chunks +0 lines, -10 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (9 generated)
David Trainor- moved to gerrit
ptal thanks!
3 years, 8 months ago (2017-03-28 22:43:44 UTC) #2
qinmin
lgtm
3 years, 8 months ago (2017-03-29 16:27:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771353002/40001
3 years, 8 months ago (2017-03-30 01:33:17 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 03:27:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/008b3fe04b6cefb33e44ebb30c4a...

Powered by Google App Engine
This is Rietveld 408576698