Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5446)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java

Issue 2771353002: Don't force the download notifier to unbind (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java b/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java
index b5016400ce57b929d9e76e06997266a0e1f8c148..0b85862002cdfc88bfb8d891f88530a6aa9fa09c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java
@@ -114,11 +114,6 @@ public class SystemDownloadNotifier implements DownloadNotifier, Observer {
void handlePendingNotifications() {
if (mPendingNotifications.isEmpty()) return;
for (int i = 0; i < mPendingNotifications.size(); i++) {
- // If we lose the service mid-loop retrigger the service load and quit.
- if (mBoundService == null) {
- startAndBindToServiceIfNeeded();
- return;
- }
updateDownloadNotification(
mPendingNotifications.get(i), i == mPendingNotifications.size() - 1);
}
@@ -159,11 +154,6 @@ public class SystemDownloadNotifier implements DownloadNotifier, Observer {
}
@Override
- public void onServiceShutdownRequested() {
- unbindServiceIfNeeded();
- }
-
- @Override
public void onDownloadCanceled(ContentId id) {
mActiveDownloads.remove(id.id);
if (mActiveDownloads.isEmpty()) unbindServiceIfNeeded();
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698