Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2771293002: Log foreground duration for failed provisional loads. (Closed)

Created:
3 years, 9 months ago by Bryan McQuade
Modified:
3 years, 9 months ago
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Log foreground duration for failed provisional loads. UKM logs foreground duration for both committed and provisional loads. This change makes core UMA metrics more consistent with UKM. This metric will also help to measure the impact of the delayed navigation experiment, where we expect there to be an increased number of failed provisional loads. BUG=705058 Review-Url: https://codereview.chromium.org/2771293002 Cr-Commit-Position: refs/heads/master@{#459576} Committed: https://chromium.googlesource.com/chromium/src/+/8db499251a795b754dbef05b1d73a5e877001da8

Patch Set 1 #

Patch Set 2 : add histograms.xml entry #

Patch Set 3 : fix wording #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -7 lines) Patch
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc View 7 chunks +24 lines, -5 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
Bryan McQuade
PTAL, thanks!
3 years, 9 months ago (2017-03-24 20:18:06 UTC) #6
Bryan McQuade
isherman, PTAL for histograms.xml, thanks!
3 years, 9 months ago (2017-03-24 20:24:31 UTC) #11
Charlie Harrison
LGTM
3 years, 9 months ago (2017-03-24 20:44:10 UTC) #14
Ilya Sherman
histograms.xml lgtm
3 years, 9 months ago (2017-03-24 22:08:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771293002/40001
3 years, 9 months ago (2017-03-24 22:18:52 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 22:27:06 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8db499251a795b754dbef05b1d73...

Powered by Google App Engine
This is Rietveld 408576698