chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc - Issue 2771293002: Log foreground duration for failed provisional loads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 2771293002: Log foreground duration for failed provisional loads. (Closed)

Patch Set: fix wording Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

index 2d106d40557fe041d9f1cf8967da55cf993f3778..f109f3b265cb5639ef4da4e470bc2c73ed91c87d 100644

--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

@@ -322,6 +322,11 @@ TEST_F(CorePageLoadMetricsObserverTest, FailedProvisionalLoad) {

histogram_tester().ExpectTotalCount(internal::kHistogramFirstTextPaint, 0);

histogram_tester().ExpectTotalCount(internal::kHistogramFailedProvisionalLoad,

1);

+ histogram_tester().ExpectTotalCount(

+ internal::kHistogramPageTimingForegroundDuration, 0);

+ histogram_tester().ExpectTotalCount(

+ internal::kHistogramPageTimingForegroundDurationNoCommit, 1);

}

TEST_F(CorePageLoadMetricsObserverTest, FailedBackgroundProvisionalLoad) {