Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2771033006: PartitionDumpStats(): reduce stack consumption for 'light' reporting. (Closed)

Created:
3 years, 9 months ago by sof
Modified:
3 years, 9 months ago
Reviewers:
palmer, haraken
CC:
chromium-reviews, Dai Mikurube (NOT FULLTIME), Mads Ager (chromium), vmpstr+watch_chromium.org, wfh+watch_chromium.org, oilpan-reviews, kouhei+heap_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PartitionDumpStats(): reduce stack consumption for 'light' reporting. Following r456291's lead, avoid putting a large array on the stack for light stats reporting in PartitionDumpStats(), where it isn't made use of. This avoids running into stack pressure when sampling memory use in production builds (on Windows, in particular.) R=haraken BUG=704894 Review-Url: https://codereview.chromium.org/2771033006 Cr-Commit-Position: refs/heads/master@{#459498} Committed: https://chromium.googlesource.com/chromium/src/+/06fe872f1501d6ea1f79ce592555da1d766c0a7a

Patch Set 1 #

Patch Set 2 : triv Blink change to trigger webkit_tests... #

Patch Set 3 : undo ps#2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -15 lines) Patch
M base/allocator/partition_allocator/partition_alloc.cc View 1 chunk +30 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sof
please take a look. https://codereview.chromium.org/2741853007 applied to PartitionDumpStats() (at least that's the intent.) Will undo ...
3 years, 9 months ago (2017-03-24 14:59:35 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-03-24 15:15:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771033006/40001
3 years, 9 months ago (2017-03-24 16:27:08 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 18:55:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/06fe872f1501d6ea1f79ce592555...

Powered by Google App Engine
This is Rietveld 408576698