Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2741853007:
PartitionAlloc: use less stack when dumping stats. (Closed)
|
Created:
3 years, 9 months ago by sof Modified:
3 years, 9 months ago CC:
chromium-reviews, Dai Mikurube (NOT FULLTIME), Mads Ager (chromium), vmpstr+watch_chromium.org, wfh+watch_chromium.org, oilpan-reviews, kouhei+heap_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPartitionAlloc: use less stack when dumping stats.
Avoid unnecessary stack usage in PartitionDumpStatsGeneric() for
the intermediate array of sizes used for full stats reporting.
Full stat dumps are currently only made use of by unit tests,
light reports do not make really use of an intermediate array and
allocation can be avoided for those. Addressing some reported
stack overflow failures (Windows.)
R=haraken
BUG=699893, 699922
Review-Url: https://codereview.chromium.org/2741853007
Cr-Commit-Position: refs/heads/master@{#456291}
Committed: https://chromium.googlesource.com/chromium/src/+/b05116a81a5b5c1efc34ef7c0fa96a9939749b3e
Patch Set 1 #Patch Set 2 : check is_valid flag before sampling bucket stat #Patch Set 3 : trigger webkit_tests.. #Patch Set 4 : undo ps#3 #Messages
Total messages: 26 (22 generated)
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== PartitionAlloc: use less stack when dumping stats. Avoid unnecessary stack usage in PartitionDumpStatsGeneric() for the intermediate array of map sizes used for full stats reporting. R= BUG=699893 ========== to ========== PartitionAlloc: use less stack when dumping stats. Avoid unnecessary stack usage in PartitionDumpStatsGeneric() for the intermediate array of sizes used for full stats reporting. Full stat dumps are currently only made use of by unit tests, light reporting doesn't make use of the intermediate array and allocation can be avoided. Along with some reported Windows stack overflows. R= BUG=699893 ==========
Description was changed from ========== PartitionAlloc: use less stack when dumping stats. Avoid unnecessary stack usage in PartitionDumpStatsGeneric() for the intermediate array of sizes used for full stats reporting. Full stat dumps are currently only made use of by unit tests, light reporting doesn't make use of the intermediate array and allocation can be avoided. Along with some reported Windows stack overflows. R= BUG=699893 ========== to ========== PartitionAlloc: use less stack when dumping stats. Avoid unnecessary stack usage in PartitionDumpStatsGeneric() for the intermediate array of sizes used for full stats reporting. Full stat dumps are currently only made use of by unit tests, light reporting doesn't make use of the intermediate array and allocation can be avoided. Along with some reported Windows stack overflows. R= BUG=699893, 699922 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== PartitionAlloc: use less stack when dumping stats. Avoid unnecessary stack usage in PartitionDumpStatsGeneric() for the intermediate array of sizes used for full stats reporting. Full stat dumps are currently only made use of by unit tests, light reporting doesn't make use of the intermediate array and allocation can be avoided. Along with some reported Windows stack overflows. R= BUG=699893, 699922 ========== to ========== PartitionAlloc: use less stack when dumping stats. Avoid unnecessary stack usage in PartitionDumpStatsGeneric() for the intermediate array of sizes used for full stats reporting. Full stat dumps are currently only made use of by unit tests, light reports do not make really use of an intermediate array and allocation can be avoided for those. Addressing some reported stack overflow failures (Windows.) R= BUG=699893, 699922 ==========
sigbjornf@opera.com changed reviewers: + haraken@chromium.org, palmer@chromium.org
please take a look.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
Description was changed from ========== PartitionAlloc: use less stack when dumping stats. Avoid unnecessary stack usage in PartitionDumpStatsGeneric() for the intermediate array of sizes used for full stats reporting. Full stat dumps are currently only made use of by unit tests, light reports do not make really use of an intermediate array and allocation can be avoided for those. Addressing some reported stack overflow failures (Windows.) R= BUG=699893, 699922 ========== to ========== PartitionAlloc: use less stack when dumping stats. Avoid unnecessary stack usage in PartitionDumpStatsGeneric() for the intermediate array of sizes used for full stats reporting. Full stat dumps are currently only made use of by unit tests, light reports do not make really use of an intermediate array and allocation can be avoided for those. Addressing some reported stack overflow failures (Windows.) R=haraken BUG=699893, 699922 ==========
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489259473262770,
"parent_rev": "94c44abd2c1a34bf882365953743311fa9a0ff19", "commit_rev":
"b05116a81a5b5c1efc34ef7c0fa96a9939749b3e"}
Message was sent while issue was closed.
Description was changed from ========== PartitionAlloc: use less stack when dumping stats. Avoid unnecessary stack usage in PartitionDumpStatsGeneric() for the intermediate array of sizes used for full stats reporting. Full stat dumps are currently only made use of by unit tests, light reports do not make really use of an intermediate array and allocation can be avoided for those. Addressing some reported stack overflow failures (Windows.) R=haraken BUG=699893, 699922 ========== to ========== PartitionAlloc: use less stack when dumping stats. Avoid unnecessary stack usage in PartitionDumpStatsGeneric() for the intermediate array of sizes used for full stats reporting. Full stat dumps are currently only made use of by unit tests, light reports do not make really use of an intermediate array and allocation can be avoided for those. Addressing some reported stack overflow failures (Windows.) R=haraken BUG=699893, 699922 Review-Url: https://codereview.chromium.org/2741853007 Cr-Commit-Position: refs/heads/master@{#456291} Committed: https://chromium.googlesource.com/chromium/src/+/b05116a81a5b5c1efc34ef7c0fa9... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/b05116a81a5b5c1efc34ef7c0fa9... |
