Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 2770953002: Revert of gpu: Add a util method to set crash-keys from a GPUInfo. (Closed)

Created:
3 years, 9 months ago by Will Harris
Modified:
3 years, 9 months ago
CC:
chromium-reviews, piman+watch_chromium.org, android-webview-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of gpu: Add a util method to set crash-keys from a GPUInfo. (patchset #2 id:20001 of https://codereview.chromium.org/2751103008/ ) Reason for revert: causes size regression see crbug.com/703622 Original issue's description: > gpu: Add a util method to set crash-keys from a GPUInfo. > > Use the newly introduced util method to set crash-keys from a GPUInfo > in both chrome and android_webview. This will also be used in mus. > > BUG=643746 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2751103008 > Cr-Commit-Position: refs/heads/master@{#458276} > Committed: https://chromium.googlesource.com/chromium/src/+/1432276fb82ae8e9b732faa03ab65f35d686017f TBR=boliu@chromium.org,bradnelson@chromium.org,rsesek@chromium.org,piman@chromium.org,jam@chromium.org,sadrul@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=643746, 703622 Review-Url: https://codereview.chromium.org/2770953002 Cr-Commit-Position: refs/heads/master@{#458968} Committed: https://chromium.googlesource.com/chromium/src/+/aa9787bbd7919d6114c6bb40fe8e30cdae424ba1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -81 lines) Patch
M android_webview/common/aw_content_client.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_content_client.cc View 2 chunks +18 lines, -2 lines 0 comments Download
M chrome/common/crash_keys.h View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/common/crash_keys.cc View 3 chunks +23 lines, -10 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/broker/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/config/gpu_util.h View 2 chunks +0 lines, -21 lines 0 comments Download
M gpu/config/gpu_util.cc View 3 chunks +0 lines, -43 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Will Harris
Created Revert of gpu: Add a util method to set crash-keys from a GPUInfo.
3 years, 9 months ago (2017-03-22 22:19:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770953002/1
3 years, 9 months ago (2017-03-22 22:19:49 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 01:24:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aa9787bbd7919d6114c6bb40fe8e...

Powered by Google App Engine
This is Rietveld 408576698