Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5375)

Unified Diff: chrome/common/chrome_content_client.cc

Issue 2770953002: Revert of gpu: Add a util method to set crash-keys from a GPUInfo. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/common/crash_keys.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/chrome_content_client.cc
diff --git a/chrome/common/chrome_content_client.cc b/chrome/common/chrome_content_client.cc
index b5a5ccbc266cf322ffcad8d74e2876a6a5fc6967..91acb7d5f6cee2592df87450f8da7967c4ada7cd 100644
--- a/chrome/common/chrome_content_client.cc
+++ b/chrome/common/chrome_content_client.cc
@@ -43,7 +43,6 @@
#include "extensions/common/constants.h"
#include "extensions/features/features.h"
#include "gpu/config/gpu_info.h"
-#include "gpu/config/gpu_util.h"
#include "media/media_features.h"
#include "net/http/http_util.h"
#include "pdf/features.h"
@@ -450,7 +449,24 @@
}
void ChromeContentClient::SetGpuInfo(const gpu::GPUInfo& gpu_info) {
- gpu::SetKeysForCrashLogging(gpu_info);
+#if !defined(OS_ANDROID)
+ base::debug::SetCrashKeyValue(crash_keys::kGPUVendorID,
+ base::StringPrintf("0x%04x", gpu_info.gpu.vendor_id));
+ base::debug::SetCrashKeyValue(crash_keys::kGPUDeviceID,
+ base::StringPrintf("0x%04x", gpu_info.gpu.device_id));
+#endif
+ base::debug::SetCrashKeyValue(crash_keys::kGPUDriverVersion,
+ gpu_info.driver_version);
+ base::debug::SetCrashKeyValue(crash_keys::kGPUPixelShaderVersion,
+ gpu_info.pixel_shader_version);
+ base::debug::SetCrashKeyValue(crash_keys::kGPUVertexShaderVersion,
+ gpu_info.vertex_shader_version);
+#if defined(OS_MACOSX)
+ base::debug::SetCrashKeyValue(crash_keys::kGPUGLVersion, gpu_info.gl_version);
+#elif defined(OS_POSIX)
+ base::debug::SetCrashKeyValue(crash_keys::kGPUVendor, gpu_info.gl_vendor);
+ base::debug::SetCrashKeyValue(crash_keys::kGPURenderer, gpu_info.gl_renderer);
+#endif
}
#if BUILDFLAG(ENABLE_PLUGINS)
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/common/crash_keys.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698