[inspector] Increased chances of successful InjectedScriptSource compilation

[inspector] Increased chances of successful InjectedScriptSource compilation

- added InspectorTest.setupInjectedScriptEnvironment method which mutates current context,
- clear prototype of InjectedScript function and domAttributesWithObservableSideEffectOnGet.

Second point increases chances that injected-script-source would be successfully compiled.

BUG=chromium:693338
R=dgozman@chromium.org,luoe@chromium.org

Review-Url: https://codereview.chromium.org/2770823003
Cr-Commit-Position: refs/heads/master@{#44081}
Committed: https://chromium.googlesource.com/v8/v8/+/2629f811ea2f784e810ea9a38c1d290097cfa8e3

[kozy, 2017-03-22 22:46:50]

Description was changed from

==========
[inspector] introduce infrastructure for better InjectedScriptSource tests

- added InspectorTest.makeContextDirty method which mutates current context,
- clear prototype of InjectedScript function and
domAttributesWithObservableSideEffectOnGet.

Second point increases chances that injected-script-source would be successfully
compiled.

BUG=chromium:693338
R=dgozman@chromium.org,luoe@chromium.org
==========

to

==========
[inspector] increase successful compilation chances for InjectedScriptSource 

- added InspectorTest.makeContextDirty method which mutates current context,
- clear prototype of InjectedScript function and
domAttributesWithObservableSideEffectOnGet.

Second point increases chances that injected-script-source would be successfully
compiled.

BUG=chromium:693338
R=dgozman@chromium.org,luoe@chromium.org
==========

[kozy, 2017-03-22 22:47:33]

Description was changed from

==========
[inspector] increase successful compilation chances for InjectedScriptSource 

- added InspectorTest.makeContextDirty method which mutates current context,
- clear prototype of InjectedScript function and
domAttributesWithObservableSideEffectOnGet.

Second point increases chances that injected-script-source would be successfully
compiled.

BUG=chromium:693338
R=dgozman@chromium.org,luoe@chromium.org
==========

to

==========
[inspector] Increased chances of successful InjectedScriptSource compilation

- added InspectorTest.makeContextDirty method which mutates current context,
- clear prototype of InjectedScript function and
domAttributesWithObservableSideEffectOnGet.

Second point increases chances that injected-script-source would be successfully
compiled.

BUG=chromium:693338
R=dgozman@chromium.org,luoe@chromium.org
==========

[kozy, 2017-03-22 22:52:49]

Dmitry and Erik, please take a look.
First of all, this CL addresses linked issue.
Second, InspectorTest.makeContextDirty method is introduced, this method makes
current context harmful. This method could be called before calling to
injected-script-source related protocol methods, e.g. Runtime.evaluate,
Runtime.getProperties to check that they work good.
Third, we should better clear prototype of objects in InjectedScriptSource.

Roadmap:
- add InspectorTest.makeContextDirty  to most part of runtime and maybe part of
debugger tests,
- introduce builtins,
- make context more harmful,
- measure test coverage of injected-script-source.js.

Potential result: observable-effects-free injected-script-source without painful
moving of everything to native.

[kozy, 2017-03-22 22:54:54]

https://codereview.chromium.org/2770823003/diff/1/test/inspector/protocol-tes...
File test/inspector/protocol-test.js (right):

https://codereview.chromium.org/2770823003/diff/1/test/inspector/protocol-tes...
test/inspector/protocol-test.js:345: InspectorTest.log('WARNING:
InspectorTest.makeContextDirty with debug flag for debugging only and should not
be landed.');
with this flag we pause on first invocation of something bad in harmful context
and can check what getter actually was called and what stack in
injected-script-source lead to this invocation.

[dgozman, 2017-03-23 21:05:22]

lgtm

https://codereview.chromium.org/2770823003/diff/1/test/inspector/runtime/runt...
File test/inspector/runtime/runtime-evaluate-with-dirty-context.js (right):

https://codereview.chromium.org/2770823003/diff/1/test/inspector/runtime/runt...
test/inspector/runtime/runtime-evaluate-with-dirty-context.js:7:
Protocol.Runtime.evaluate({expression: 'console.log(42)'})
Let's also listen to consoleAPICalled and dump it.

[kozy, 2017-03-24 00:30:48]

all done, thanks!

https://codereview.chromium.org/2770823003/diff/1/test/inspector/runtime/runt...
File test/inspector/runtime/runtime-evaluate-with-dirty-context.js (right):

https://codereview.chromium.org/2770823003/diff/1/test/inspector/runtime/runt...
test/inspector/runtime/runtime-evaluate-with-dirty-context.js:7:
Protocol.Runtime.evaluate({expression: 'console.log(42)'})
On 2017/03/23 21:05:22, dgozman wrote:
> Let's also listen to consoleAPICalled and dump it.

Done.

[kozy, 2017-03-24 00:30:55]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-03-24 00:30:55]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2770823003/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-03-24 00:31:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2017-03-24 00:31:10]

Description was changed from

==========
[inspector] Increased chances of successful InjectedScriptSource compilation

- added InspectorTest.makeContextDirty method which mutates current context,
- clear prototype of InjectedScript function and
domAttributesWithObservableSideEffectOnGet.

Second point increases chances that injected-script-source would be successfully
compiled.

BUG=chromium:693338
R=dgozman@chromium.org,luoe@chromium.org
==========

to

==========
[inspector] Increased chances of successful InjectedScriptSource compilation

- added InspectorTest.setupInjectedScriptEnvironment method which mutates
current context,
- clear prototype of InjectedScript function and
domAttributesWithObservableSideEffectOnGet.

Second point increases chances that injected-script-source would be successfully
compiled.

BUG=chromium:693338
R=dgozman@chromium.org,luoe@chromium.org
==========

[commit-bot: I haz the power, 2017-03-24 00:48:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 00:48:04]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)
  v8_linux_verify_csa_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng_...)

[kozy, 2017-03-24 01:09:35]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-03-24 01:09:35]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2770823003/#ps40001
(title: "fixed .isolate")

[commit-bot: I haz the power, 2017-03-24 01:09:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 01:33:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490317775370120,
"parent_rev": "4e9ca1031dd5630c159de84d75c7529717c3bcab", "commit_rev":
"2629f811ea2f784e810ea9a38c1d290097cfa8e3"}

[commit-bot: I haz the power, 2017-03-24 01:33:18]

Description was changed from

==========
[inspector] Increased chances of successful InjectedScriptSource compilation

- added InspectorTest.setupInjectedScriptEnvironment method which mutates
current context,
- clear prototype of InjectedScript function and
domAttributesWithObservableSideEffectOnGet.

Second point increases chances that injected-script-source would be successfully
compiled.

BUG=chromium:693338
R=dgozman@chromium.org,luoe@chromium.org
==========

to

==========
[inspector] Increased chances of successful InjectedScriptSource compilation

- added InspectorTest.setupInjectedScriptEnvironment method which mutates
current context,
- clear prototype of InjectedScript function and
domAttributesWithObservableSideEffectOnGet.

Second point increases chances that injected-script-source would be successfully
compiled.

BUG=chromium:693338
R=dgozman@chromium.org,luoe@chromium.org

Review-Url: https://codereview.chromium.org/2770823003
Cr-Commit-Position: refs/heads/master@{#44081}
Committed:
https://chromium.googlesource.com/v8/v8/+/2629f811ea2f784e810ea9a38c1d290097c...
==========

[commit-bot: I haz the power, 2017-03-24 01:33:19]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/2629f811ea2f784e810ea9a38c1d290097c...