Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: src/inspector/v8-injected-script-host.h

Issue 2770823003: [inspector] Increased chances of successful InjectedScriptSource compilation (Closed)
Patch Set: fixed .isolate Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/inspector/injected_script_externs.js ('k') | src/inspector/v8-injected-script-host.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_INSPECTOR_V8INJECTEDSCRIPTHOST_H_ 5 #ifndef V8_INSPECTOR_V8INJECTEDSCRIPTHOST_H_
6 #define V8_INSPECTOR_V8INJECTEDSCRIPTHOST_H_ 6 #define V8_INSPECTOR_V8INJECTEDSCRIPTHOST_H_
7 7
8 #include "include/v8.h" 8 #include "include/v8.h"
9 9
10 namespace v8_inspector { 10 namespace v8_inspector {
11 11
12 class V8InspectorImpl; 12 class V8InspectorImpl;
13 13
14 // SECURITY NOTE: Although the InjectedScriptHost is intended for use solely by 14 // SECURITY NOTE: Although the InjectedScriptHost is intended for use solely by
15 // the inspector, 15 // the inspector,
16 // a reference to the InjectedScriptHost may be leaked to the page being 16 // a reference to the InjectedScriptHost may be leaked to the page being
17 // inspected. Thus, the 17 // inspected. Thus, the
18 // InjectedScriptHost must never implemment methods that have more power over 18 // InjectedScriptHost must never implemment methods that have more power over
19 // the page than the 19 // the page than the
20 // page already has itself (e.g. origin restriction bypasses). 20 // page already has itself (e.g. origin restriction bypasses).
21 21
22 class V8InjectedScriptHost { 22 class V8InjectedScriptHost {
23 public: 23 public:
24 // We expect that debugger outlives any JS context and thus 24 // We expect that debugger outlives any JS context and thus
25 // V8InjectedScriptHost (owned by JS) 25 // V8InjectedScriptHost (owned by JS)
26 // is destroyed before inspector. 26 // is destroyed before inspector.
27 static v8::Local<v8::Object> create(v8::Local<v8::Context>, V8InspectorImpl*); 27 static v8::Local<v8::Object> create(v8::Local<v8::Context>, V8InspectorImpl*);
28 28
29 private: 29 private:
30 static void nullifyPrototypeCallback(
31 const v8::FunctionCallbackInfo<v8::Value>&);
30 static void internalConstructorNameCallback( 32 static void internalConstructorNameCallback(
31 const v8::FunctionCallbackInfo<v8::Value>&); 33 const v8::FunctionCallbackInfo<v8::Value>&);
32 static void formatAccessorsAsProperties( 34 static void formatAccessorsAsProperties(
33 const v8::FunctionCallbackInfo<v8::Value>&); 35 const v8::FunctionCallbackInfo<v8::Value>&);
34 static void subtypeCallback(const v8::FunctionCallbackInfo<v8::Value>&); 36 static void subtypeCallback(const v8::FunctionCallbackInfo<v8::Value>&);
35 static void getInternalPropertiesCallback( 37 static void getInternalPropertiesCallback(
36 const v8::FunctionCallbackInfo<v8::Value>&); 38 const v8::FunctionCallbackInfo<v8::Value>&);
37 static void objectHasOwnPropertyCallback( 39 static void objectHasOwnPropertyCallback(
38 const v8::FunctionCallbackInfo<v8::Value>&); 40 const v8::FunctionCallbackInfo<v8::Value>&);
39 static void bindCallback(const v8::FunctionCallbackInfo<v8::Value>&); 41 static void bindCallback(const v8::FunctionCallbackInfo<v8::Value>&);
40 static void proxyTargetValueCallback( 42 static void proxyTargetValueCallback(
41 const v8::FunctionCallbackInfo<v8::Value>&); 43 const v8::FunctionCallbackInfo<v8::Value>&);
42 }; 44 };
43 45
44 } // namespace v8_inspector 46 } // namespace v8_inspector
45 47
46 #endif // V8_INSPECTOR_V8INJECTEDSCRIPTHOST_H_ 48 #endif // V8_INSPECTOR_V8INJECTEDSCRIPTHOST_H_
OLDNEW
« no previous file with comments | « src/inspector/injected_script_externs.js ('k') | src/inspector/v8-injected-script-host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698