Export all CWV* symbols from the ios/web_view dynamic library.

ios/web_view/public/cwv_export.h

Index: ios/web_view/public/cwv_export.h
diff --git a/ios/web_view/public/cwv_export.h b/ios/web_view/public/cwv_export.h
new file mode 100644
index 0000000000000000000000000000000000000000..765ab4ec0034f50ab852845f0f313ed3b01cd65c
--- /dev/null
+++ b/ios/web_view/public/cwv_export.h
@@ -0,0 +1,24 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_WEB_VIEW_PUBLIC_CWV_EXPORT_H_
+#define IOS_WEB_VIEW_PUBLIC_CWV_EXPORT_H_
+
+// All public classes in //ios/web_view must be prefixed with CWV_EXPORT, so
+// that clients of //ios/web_view dynamic library can link them.
+//
+// This is because a dynamic library only exports symbols marked
+// __attribute__((visibility("default"))).
+//
+// Here I define a macro CWV_EXPORT instead of directly using __attribute__.

[michaeldo, 2017/03/23 15:12:42]

Remove "Here I". I can't find the reference, but we don't use "we" in comments,
and I don't believe we should have I in them either since it is arbitrary.

[Hiroshi Ichikawa, 2017/03/24 06:34:20]

Done.

+// This makes it possible to export symbols only when *building* the dynamic
+// library (by checking CWV_IMPLEMENTATION), not when *using* the dynamic
+// library.
+#if defined(CWV_IMPLEMENTATION)
+#define CWV_EXPORT __attribute__((visibility("default")))
+#else
+#define CWV_EXPORT
+#endif
+
+#endif  // IOS_WEB_VIEW_PUBLIC_CWV_EXPORT_H_