ios/web_view/internal/translate/BUILD.gn - Issue 2770633002: Export all CWV* symbols from the ios/web_view dynamic library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web_view/internal/translate/BUILD.gn

Issue 2770633002: Export all CWV* symbols from the ios/web_view dynamic library. (Closed)

Patch Set: Apply review comments. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web_view/internal/translate/BUILD.gn

diff --git a/ios/web_view/internal/translate/BUILD.gn b/ios/web_view/internal/translate/BUILD.gn

index 3c0d86a05db663d61ef27f3984db5f3a7883be24..4b9694137935a5e738e7dbafe108db7da7dd20c1 100644

--- a/ios/web_view/internal/translate/BUILD.gn

+++ b/ios/web_view/internal/translate/BUILD.gn

@@ -16,6 +16,11 @@ source_set("translate") {

"web_view_translate_client.h",

"web_view_translate_client.mm",

]

+ # Let header files know that it is building ios/web_view library, not using

+ # it.

+ defines = [ "CWV_IMPLEMENTATION" ]

deps = [

"//base",

"//components/infobars/core",