[inspector] description for weak collections should not contain size

[inspector] description for weak collections should not contain size

These JS objects don't have size property.

BUG=none
R=dgozman@chromium.org,luoe@chromium.org

Review-Url: https://codereview.chromium.org/2770583002
Cr-Commit-Position: refs/heads/master@{#44048}
Committed: https://chromium.googlesource.com/v8/v8/+/786c64e8ebf5afee7c060a25902c6cec9c85967c

[kozy, 2017-03-22 03:54:29]

Description was changed from

==========
[inspector] descriptio for weak collections should not contain size

These JS objects don't provide size.

BUG=none
R=dgozman@chromium.org,luoe@chromium.org
==========

to

==========
[inspector] description for weak collections should not contain size

These JS objects don't have size property.

BUG=none
R=dgozman@chromium.org,luoe@chromium.org
==========

[kozy, 2017-03-22 03:54:40]

Dmitry and Erik, please take a look.

[kozy, 2017-03-22 03:54:51]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 03:55:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 04:17:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 04:17:58]

Dry run: This issue passed the CQ dry run.

[kozy, 2017-03-22 04:32:55]

On 2017/03/22 03:54:40, kozy wrote:
> Dmitry and Erik, please take a look.

And yes, we need to prepare fronted first, I'll upload CL tomorrow. This is part
of the effort to avoid calling user getters in injected script source.

[luoe, 2017-03-22 19:08:00]

Changes look good, but could you explain how this helps avoid getters in ISS?

Also, can we update the subtype enum in js_protocol for "RemoteObject",
"ObjectPreview" and "PropertyPreview"?
https://cs.chromium.org/chromium/src/v8/src/inspector/js_protocol.json?q=js_p...

[dgozman, 2017-03-22 19:23:21]

On 2017/03/22 19:08:00, luoe wrote:
> Changes look good, but could you explain how this helps avoid getters in ISS?
> 
> Also, can we update the subtype enum in js_protocol for "RemoteObject",
> "ObjectPreview" and "PropertyPreview"?
>
https://cs.chromium.org/chromium/src/v8/src/inspector/js_protocol.json?q=js_p...

+1 for updating protocol, lgtm otherwise

[kozy, 2017-03-22 21:11:05]

On 2017/03/22 19:08:00, luoe wrote:
> Changes look good, but could you explain how this helps avoid getters in ISS?
> 
> Also, can we update the subtype enum in js_protocol for "RemoteObject",
> "ObjectPreview" and "PropertyPreview"?
>
https://cs.chromium.org/chromium/src/v8/src/inspector/js_protocol.json?q=js_p...

Added to protocol.
I'm currently working on fixing crash, the reason of crash is that we call
getters from user code in injected-script-source, during this work I found that
we call size on weak collections, but these collections don't have this property
and fallback to user defined getter on Object.
I'll upload CL this week which focused on remove all places where we potentially
can call getters from injected-script-source.js and describes in more details
what actually happens..
This CL by itself just remove one possible place where we call incorrect user
getter.

[kozy, 2017-03-22 21:11:13]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 21:11:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2017-03-22 21:15:02]

The CQ bit was unchecked by kozyatinskiy@chromium.org

[kozy, 2017-03-22 21:15:06]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-03-22 21:15:07]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2770583002/#ps20001
(title: "added to protocol")

[commit-bot: I haz the power, 2017-03-22 21:15:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 21:35:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490217306896600,
"parent_rev": "9d8d4dfa7dfdd226f63a58e054082817e8f27dc6", "commit_rev":
"786c64e8ebf5afee7c060a25902c6cec9c85967c"}

[commit-bot: I haz the power, 2017-03-22 21:35:19]

Description was changed from

==========
[inspector] description for weak collections should not contain size

These JS objects don't have size property.

BUG=none
R=dgozman@chromium.org,luoe@chromium.org
==========

to

==========
[inspector] description for weak collections should not contain size

These JS objects don't have size property.

BUG=none
R=dgozman@chromium.org,luoe@chromium.org

Review-Url: https://codereview.chromium.org/2770583002
Cr-Commit-Position: refs/heads/master@{#44048}
Committed:
https://chromium.googlesource.com/v8/v8/+/786c64e8ebf5afee7c060a25902c6cec9c8...
==========

[commit-bot: I haz the power, 2017-03-22 21:35:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/786c64e8ebf5afee7c060a25902c6cec9c8...