Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1594)

Unified Diff: src/inspector/v8-injected-script-host.cc

Issue 2770583002: [inspector] description for weak collections should not contain size (Closed)
Patch Set: added to protocol Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/js_protocol.json ('k') | test/inspector/runtime/length-or-size-description.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-injected-script-host.cc
diff --git a/src/inspector/v8-injected-script-host.cc b/src/inspector/v8-injected-script-host.cc
index 3748ec9aa302aab22c8ff8366606f3ead9825a41..d3e89d9d7b8382523bbfca91ae101b663abf1a69 100644
--- a/src/inspector/v8-injected-script-host.cc
+++ b/src/inspector/v8-injected-script-host.cc
@@ -127,14 +127,22 @@ void V8InjectedScriptHost::subtypeCallback(
info.GetReturnValue().Set(toV8StringInternalized(isolate, "regexp"));
return;
}
- if (value->IsMap() || value->IsWeakMap()) {
+ if (value->IsMap()) {
info.GetReturnValue().Set(toV8StringInternalized(isolate, "map"));
return;
}
- if (value->IsSet() || value->IsWeakSet()) {
+ if (value->IsWeakMap()) {
+ info.GetReturnValue().Set(toV8StringInternalized(isolate, "weakmap"));
+ return;
+ }
+ if (value->IsSet()) {
info.GetReturnValue().Set(toV8StringInternalized(isolate, "set"));
return;
}
+ if (value->IsWeakSet()) {
+ info.GetReturnValue().Set(toV8StringInternalized(isolate, "weakset"));
+ return;
+ }
if (value->IsMapIterator() || value->IsSetIterator()) {
info.GetReturnValue().Set(toV8StringInternalized(isolate, "iterator"));
return;
« no previous file with comments | « src/inspector/js_protocol.json ('k') | test/inspector/runtime/length-or-size-description.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698