DevTools: kill Common.Throttler.flush() method

DevTools: kill Common.Throttler.flush() method

It turns out that Common.Throttler.flush() method could not be implemented
safely since it causes re-enterability for the clients. (consider calling
throttler.flush() during the async process being executed).

This patch kills the method and migrates its clients off.

BUG=none
R=caseq

Review-Url: https://codereview.chromium.org/2770523002
Cr-Commit-Position: refs/heads/master@{#458636}
Committed: https://chromium.googlesource.com/chromium/src/+/0f53221a743754f2bd21257c2f96c2486aca0023

[lushnikov, 2017-03-22 00:54:38]

please, take a look

https://codereview.chromium.org/2770523002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
(right):

https://codereview.chromium.org/2770523002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:350:
_invalidateViewport() {
this change is pulling function invalidateViewport out from closure

[lushnikov, 2017-03-22 00:54:42]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 00:55:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caseq, 2017-03-22 01:40:23]

lgtm

[lushnikov, 2017-03-22 01:46:36]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2017-03-22 03:45:24]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-03-22 03:46:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 05:13:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490154324134400, "parent_rev":
"a6bfb94ddcb95eef883d62b3d65de8e13192e90c", "commit_rev":
"0f53221a743754f2bd21257c2f96c2486aca0023"}

[commit-bot: I haz the power, 2017-03-22 05:14:19]

Description was changed from

==========
DevTools: kill Common.Throttler.flush() method

It turns out that Common.Throttler.flush() method could not be implemented
safely since it causes re-enterability for the clients. (consider calling
throttler.flush() during the async process being executed).

This patch kills the method and migrates its clients off.

BUG=none
R=caseq
==========

to

==========
DevTools: kill Common.Throttler.flush() method

It turns out that Common.Throttler.flush() method could not be implemented
safely since it causes re-enterability for the clients. (consider calling
throttler.flush() during the async process being executed).

This patch kills the method and migrates its clients off.

BUG=none
R=caseq

Review-Url: https://codereview.chromium.org/2770523002
Cr-Commit-Position: refs/heads/master@{#458636}
Committed:
https://chromium.googlesource.com/chromium/src/+/0f53221a743754f2bd21257c2f96...
==========

[commit-bot: I haz the power, 2017-03-22 05:14:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0f53221a743754f2bd21257c2f96...