Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2770523002: DevTools: kill Common.Throttler.flush() method (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
index 091f477aedea3857e56425292976ab93ea538837..f32a81cb77740992c205ca6d7cf49bd71010f00a 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
@@ -344,24 +344,24 @@ Console.ConsoleView = class extends UI.VBox {
this._prompt.clearAutocomplete();
}
- _scheduleViewportRefresh() {
- /**
- * @this {Console.ConsoleView}
- * @return {!Promise.<undefined>}
- */
- function invalidateViewport() {
- if (this._muteViewportUpdates) {
- this._maybeDirtyWhileMuted = true;
- return Promise.resolve();
- }
- if (this._needsFullUpdate) {
- this._updateMessageList();
- delete this._needsFullUpdate;
- } else {
- this._viewport.invalidate();
- }
+ /**
+ * @return {!Promise.<undefined>}
+ */
+ _invalidateViewport() {
lushnikov 2017/03/22 00:54:37 this change is pulling function invalidateViewport
+ if (this._muteViewportUpdates) {
+ this._maybeDirtyWhileMuted = true;
return Promise.resolve();
}
+ if (this._needsFullUpdate) {
+ this._updateMessageList();
+ delete this._needsFullUpdate;
+ } else {
+ this._viewport.invalidate();
+ }
+ return Promise.resolve();
+ }
+
+ _scheduleViewportRefresh() {
if (this._muteViewportUpdates) {
this._maybeDirtyWhileMuted = true;
this._scheduleViewportRefreshForTest(true);
@@ -369,7 +369,7 @@ Console.ConsoleView = class extends UI.VBox {
} else {
this._scheduleViewportRefreshForTest(false);
}
- this._viewportThrottler.schedule(invalidateViewport.bind(this));
+ this._viewportThrottler.schedule(this._invalidateViewport.bind(this));
}
/**

Powered by Google App Engine
This is Rietveld 408576698