Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1165)

Issue 2770333002: Merge to M58: AXObject::performDefaultAction() should focus if it can't click (Closed)

Created:
3 years, 9 months ago by dmazzoni
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, haraken, nektarios, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, blink-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Merge to M58: AXObject::performDefaultAction() should focus if it can't click The user-visible bug here is that sending a CLICK event to a text field on Android does nothing, because a text field doesn't have a default action. I could fix this on the Android side, but this seems wrong to me. If performDefaultAction() is called on a focusable control, I think the natural thing to do is focus it if there's no "press" behavior. So I think we should handle that generally. Let me know if you have any objection and I could make it more narrow. But to me it seems more useful this way. BUG=703659 Review-Url: https://codereview.chromium.org/2772913003 Cr-Commit-Position: refs/heads/master@{#459448} (cherry picked from commit cbf2ebc6e589a5aa81d29c78cf392182de4329bb) Review-Url: https://codereview.chromium.org/2770333002 . Cr-Commit-Position: refs/branch-heads/3029@{#413} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/abb8b3588f8f814d9dec639b9c3a3208ad132478

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
dmazzoni
3 years, 9 months ago (2017-03-24 20:16:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
abb8b3588f8f814d9dec639b9c3a3208ad132478.

Powered by Google App Engine
This is Rietveld 408576698