Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 277033003: Modify pnacl subzero to be able to read pnacl bitcode files. (Closed)

Created:
6 years, 7 months ago by Karl
Modified:
6 years, 7 months ago
Reviewers:
Jim Stichnoth, JF
CC:
native-client-reviews_googlegroups.com
Base URL:
https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Modify pnacl subzero to be able to read pnacl bitcode files. BUG=None

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix test files to also test PNaCl bitcode files. #

Total comments: 12

Patch Set 3 : Fix issues raised in CL patch set 2. #

Total comments: 7

Patch Set 4 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -193 lines) Patch
A llvm2iceinsts.py View 1 2 3 1 chunk +68 lines, -0 lines 0 comments Download
A pydir/utils.py View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/llvm2ice.cpp View 1 3 chunks +12 lines, -2 lines 0 comments Download
M szdiff.py View 1 2 3 2 chunks +21 lines, -25 lines 0 comments Download
M tests_lit/lit.cfg View 1 1 chunk +7 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/64bit.pnacl.ll View 1 3 chunks +7 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/alloc.ll View 1 2 chunks +7 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/arith-opt.ll View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/arithmetic-chain.ll View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/bitcast.ll View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/bool-opt.ll View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/branch-simple.ll View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/call.ll View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/callindirect.pnacl.ll View 1 2 chunks +9 lines, -7 lines 0 comments Download
M tests_lit/llvm2ice_tests/casts.ll View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/cmp-opt.ll View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/convert.ll View 1 8 chunks +75 lines, -45 lines 0 comments Download
M tests_lit/llvm2ice_tests/empty-func.ll View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/fp.pnacl.ll View 1 5 chunks +11 lines, -9 lines 0 comments Download
M tests_lit/llvm2ice_tests/fpconst.pnacl.ll View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/global.ll View 1 1 chunk +10 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/icmp-simple.ll View 1 1 chunk +3 lines, -1 line 0 comments Download
D tests_lit/llvm2ice_tests/inttoptr.ll View 1 1 chunk +0 lines, -13 lines 0 comments Download
M tests_lit/llvm2ice_tests/load.ll View 1 1 chunk +15 lines, -13 lines 0 comments Download
M tests_lit/llvm2ice_tests/return-int-arg.ll View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/select-opt.ll View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/shift.ll View 1 2 chunks +14 lines, -9 lines 0 comments Download
M tests_lit/llvm2ice_tests/simple-arith.ll View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/simple-cond.ll View 1 2 chunks +5 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/simple-loop.ll View 1 2 chunks +5 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/store.ll View 1 1 chunk +15 lines, -13 lines 0 comments Download
M tests_lit/llvm2ice_tests/struct-arith.pnacl.ll View 1 2 chunks +20 lines, -18 lines 0 comments Download
M tests_lit/llvm2ice_tests/switch-opt.ll View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/unreachable.ll View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Karl
PTAL. Thanks.
6 years, 7 months ago (2014-05-09 20:28:17 UTC) #1
Jim Stichnoth
https://codereview.chromium.org/277033003/diff/1/src/llvm2ice.cpp File src/llvm2ice.cpp (right): https://codereview.chromium.org/277033003/diff/1/src/llvm2ice.cpp#newcode597 src/llvm2ice.cpp:597: cl::opt<NaClFileFormat> Make this static for consistency with other cl::opt ...
6 years, 7 months ago (2014-05-09 23:02:42 UTC) #2
Karl
https://codereview.chromium.org/277033003/diff/1/src/llvm2ice.cpp File src/llvm2ice.cpp (right): https://codereview.chromium.org/277033003/diff/1/src/llvm2ice.cpp#newcode597 src/llvm2ice.cpp:597: cl::opt<NaClFileFormat> On 2014/05/09 23:02:42, stichnot wrote: > Make this ...
6 years, 7 months ago (2014-05-14 19:31:26 UTC) #3
Jim Stichnoth
https://codereview.chromium.org/277033003/diff/20001/llvm2iceinsts.py File llvm2iceinsts.py (right): https://codereview.chromium.org/277033003/diff/20001/llvm2iceinsts.py#newcode7 llvm2iceinsts.py:7: import re Sort imports alphabetically. (I know some or ...
6 years, 7 months ago (2014-05-14 21:45:18 UTC) #4
Karl
https://codereview.chromium.org/277033003/diff/20001/llvm2iceinsts.py File llvm2iceinsts.py (right): https://codereview.chromium.org/277033003/diff/20001/llvm2iceinsts.py#newcode7 llvm2iceinsts.py:7: import re On 2014/05/14 21:45:18, stichnot wrote: > Sort ...
6 years, 7 months ago (2014-05-14 21:56:56 UTC) #5
Jim Stichnoth
LGTM (though I could be missing pythonic comments...)
6 years, 7 months ago (2014-05-14 22:51:22 UTC) #6
JF
lgtm besides a few style things. https://codereview.chromium.org/277033003/diff/40001/llvm2iceinsts.py File llvm2iceinsts.py (right): https://codereview.chromium.org/277033003/diff/40001/llvm2iceinsts.py#newcode13 llvm2iceinsts.py:13: break Shouldn't that ...
6 years, 7 months ago (2014-05-19 18:10:25 UTC) #7
Karl
https://codereview.chromium.org/277033003/diff/40001/llvm2iceinsts.py File llvm2iceinsts.py (right): https://codereview.chromium.org/277033003/diff/40001/llvm2iceinsts.py#newcode13 llvm2iceinsts.py:13: break On 2014/05/19 18:10:25, JF wrote: > Shouldn't that ...
6 years, 7 months ago (2014-05-19 21:34:39 UTC) #8
Karl
6 years, 7 months ago (2014-05-19 21:59:29 UTC) #9
Committed.

Powered by Google App Engine
This is Rietveld 408576698