Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2770253003: Revert of Move geometry interface files to geometry directory. (Closed)

Created:
3 years, 9 months ago by melandory
Modified:
3 years, 8 months ago
CC:
abarth-chromium, blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, esprehn
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move geometry interface files to geometry directory. (patchset #7 id:120001 of https://codereview.chromium.org/2741723005/ ) Reason for revert: Findit identified CL at revision 459398 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzczZjIyMDg4ZWIyYzk0ZGY0MmVkZDU1YWJkOWNmMWUzNDVlMThlN2MM Original issue's description: > Move geometry interface files to geometry directory. > > The geometry interfaces such as DOMMatrix, DOMRect and so on can be shared > in a lot of modules such as dom, css and so on. Also, it is not very relevant to > the DOM, so it is proper to create a new geometry directory and then move the > related files to the directory. > > [1/2] This Patch (Move DOMMatrix related files to geometry folder) > [2/2] https://codereview.chromium.org/2709763004/ (Make WebKitCSSMatrix an > alias of DOMMatrix.) > > BUG=581955 > > Review-Url: https://codereview.chromium.org/2741723005 > Cr-Commit-Position: refs/heads/master@{#459398} > Committed: https://chromium.googlesource.com/chromium/src/+/73f22088eb2c94df42edd55abd9cf1e345e18e7c TBR=dominicc@chromium.org,foolip@chromium.org,jinho.bang@samsung.com,esprehn@chromium.org,gogag2@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=581955

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1925 lines, -1944 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 3 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/core_idl_files.gni View 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/dom/BUILD.gn View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CompositorProxy.h View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/core/dom/DOMMatrix.h View 1 chunk +121 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMMatrix.cpp View 1 chunk +267 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMMatrix.idl View 1 chunk +74 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMMatrixInit.idl View 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h View 1 chunk +140 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp View 1 chunk +398 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl View 1 chunk +82 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMMatrixTest.cpp View 1 chunk +151 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMPoint.h View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMPoint.cpp View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMPoint.idl View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMPointInit.idl View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMPointReadOnly.h View 1 chunk +50 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMPointReadOnly.cpp View 1 chunk +66 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMPointReadOnly.idl View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMQuad.h View 1 chunk +70 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMQuad.cpp View 1 chunk +80 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMQuad.idl View 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMQuadInit.idl View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMRect.h View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMRect.cpp View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMRect.idl View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMRectInit.idl View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMRectReadOnly.h View 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMRectReadOnly.cpp View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DOMRectReadOnly.idl View 1 chunk +25 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/BUILD.gn View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMMatrix.h View 1 chunk +0 lines, -121 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMMatrix.cpp View 1 chunk +0 lines, -267 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMMatrix.idl View 1 chunk +0 lines, -74 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMMatrixInit.idl View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h View 1 chunk +0 lines, -140 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.cpp View 1 chunk +0 lines, -398 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.idl View 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMMatrixTest.cpp View 1 chunk +0 lines, -151 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMPoint.h View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMPoint.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMPoint.idl View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMPointInit.idl View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMPointReadOnly.h View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMPointReadOnly.cpp View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMPointReadOnly.idl View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMQuad.h View 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMQuad.cpp View 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMQuad.idl View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMQuadInit.idl View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMRect.h View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMRect.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMRect.idl View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMRectInit.idl View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMRectReadOnly.h View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMRectReadOnly.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/DOMRectReadOnly.idl View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/Source/core/geometry/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/DetectedFace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/DetectedText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
melandory
Created Revert of Move geometry interface files to geometry directory.
3 years, 9 months ago (2017-03-24 13:26:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770253003/1
3 years, 9 months ago (2017-03-24 13:26:39 UTC) #3
zino
On 2017/03/24 13:26:39, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 9 months ago (2017-03-24 13:31:05 UTC) #4
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 9 months ago (2017-03-24 13:36:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770253003/1
3 years, 9 months ago (2017-03-24 13:40:57 UTC) #9
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/BUILD.gn: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-03-24 13:41:45 UTC) #11
dgn
There is a message on the bug about this CL landing and it also appears ...
3 years, 9 months ago (2017-03-24 14:01:46 UTC) #12
melandory
On 2017/03/24 14:01:46, dgn wrote: > There is a message on the bug about this ...
3 years, 9 months ago (2017-03-24 14:03:47 UTC) #13
zino
3 years, 9 months ago (2017-03-24 14:04:11 UTC) #14
On 2017/03/24 14:01:46, dgn wrote:
> There is a message on the bug about this CL landing and it also appears in
> gitiles. But it's not marked as landed here. What is the actual status? How
was
> the merge conflict resolved?

I've just checked that it is landed successfully in latest source.

Powered by Google App Engine
This is Rietveld 408576698