Implement request id in PaymentDetailsInit

Implement request id in PaymentDetailsInit

Implement request id in PaymentDetailsInit as well as id
getter in PaymentRequest.

In order for this functionality to make sense we pass the
id to the payment app and make sure to set it in the
PaymentResponse through the requestId attribute.

Added PaymentRequestIdTest as a payment integration test for verifying
the PaymentResponse contains the free-form identifier specified in
PaymentDetailsInit.

Added PaymentRequestTest.DetailsIdIsSet unit test to verify that
PaymentDetailsInit.id is reflected in PaymentRequest.id.

Added external/wpt/payment-request/payment-request-id.https.html to test that
PaymentDetailsInit.id is reflected in PaymentRequest.id and that not providing
an id generates a UUID.

Added manual test external/wpt/payment-request/payment-request-response-id.html
for verifying the PaymentResponse contains the free-form identifier specified
in PaymentDetailsInit.

Intent to Implement and Ship thread:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/WaHAg3wh7jw/vWAqxSnOCgAJ

BUG=701254
TEST=PaymentRequestIdTest, DetailsIdIsSet

Review-Url: https://codereview.chromium.org/2770193003
Cr-Commit-Position: refs/heads/master@{#467854}
Committed: https://chromium.googlesource.com/chromium/src/+/c538713fa88d7fb0a831fbaa3b7dedafb9b5cdbf

[rwlbuis, 2017-03-24 19:22:31]

Patchset #2 (id:20001) has been deleted

[please use gerrit instead, 2017-03-24 20:14:17]

rouslan@chromium.org changed reviewers:
+ rouslan@chromium.org

[please use gerrit instead, 2017-03-24 20:14:18]

https://codereview.chromium.org/2770193003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
(right):

https://codereview.chromium.org/2770193003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:59:
private static final String EXTRA_REQUEST_ID = "requestId";
Why "requestId" instead of id"? What does the payment handler spec do?

[rwlbuis, 2017-03-27 02:31:50]

Patchset #3 (id:60001) has been deleted

[rwlbuis, 2017-03-27 13:39:25]

Patchset #3 (id:80001) has been deleted

[rwlbuis, 2017-03-27 14:30:58]

On 2017/03/24 20:14:18, ಠ_ಠ slow - w3c wrote:
>
https://codereview.chromium.org/2770193003/diff/40001/chrome/android/java/src...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
> (right):
> 
>
https://codereview.chromium.org/2770193003/diff/40001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:59:
> private static final String EXTRA_REQUEST_ID = "requestId";
> Why "requestId" instead of id"? What does the payment handler spec do?

Payment Handler has unique identifiers and calls them walletKey and
instrumentKey.

I don't really have a strong preference. We could do requestId, id, uid? I chose
requestId because id is so generic.

[please use gerrit instead, 2017-03-27 14:36:06]

I see "id" field in
https://w3c.github.io/webpayments-payment-apps-api/#sec-app-request. Let's use
that name. By the way, I see "instrumentId" in there, but no "walletKey" or
"instrumentKey". The spec seems to be changing slightly.

[rwlbuis, 2017-03-27 14:53:50]

On 2017/03/27 14:36:06, ಠ_ಠ slow - w3c wrote:
> I see "id" field in
> https://w3c.github.io/webpayments-payment-apps-api/#sec-app-request. Let's use
> that name. By the way, I see "instrumentId" in there, but no "walletKey" or
> "instrumentKey". The spec seems to be changing slightly.

InstrumentKey is here:
https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentinstruments

But id is fine with me, I'll make some changes.

[rwlbuis, 2017-03-27 15:06:11]

Description was changed from

==========
Implement requestId

BUG=701254
==========

to

==========
Implement requestId in PaymentDetails

Implement requestId in PaymentDetails as well as id
getter in PaymentRequest.

In order for this functionality to make sense we pass the
id to the payment app and make sure to set it in the
PaymentResponse being sent back to the renderer.

BUG=701254
==========

[rwlbuis, 2017-03-27 15:15:27]

On 2017/03/27 14:53:50, rwlbuis wrote:
> On 2017/03/27 14:36:06, ಠ_ಠ slow - w3c wrote:
> > I see "id" field in
> > https://w3c.github.io/webpayments-payment-apps-api/#sec-app-request. Let's
use
> > that name. By the way, I see "instrumentId" in there, but no "walletKey" or
> > "instrumentKey". The spec seems to be changing slightly.
> 
> InstrumentKey is here:
> https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentinstruments
> 
> But id is fine with me, I'll make some changes.

Done.

BTW does the id really need to be unique or only if it is not specified? Right
now Javascript can set the id to anything. Though "free-form" may indicate that
id can be set to anything...

[please use gerrit instead, 2017-03-27 15:18:53]

On 2017/03/27 15:15:27, rwlbuis wrote:
> BTW does the id really need to be unique or only if it is not specified? Right
> now Javascript can set the id to anything. Though "free-form" may indicate
that
> id can be set to anything...

If JavaScript specifies the ID, use that, regardless of what it is. It's an
opaque string to us. Otherwise, generate a GUID, which is unique.

[rwlbuis, 2017-03-27 15:34:18]

On 2017/03/27 15:18:53, ಠ_ಠ slow - w3c wrote:
> On 2017/03/27 15:15:27, rwlbuis wrote:
> > BTW does the id really need to be unique or only if it is not specified?
Right
> > now Javascript can set the id to anything. Though "free-form" may indicate
> that
> > id can be set to anything...
> 
> If JavaScript specifies the ID, use that, regardless of what it is. It's an
> opaque string to us. Otherwise, generate a GUID, which is unique.

Great, that is what I am doing ; I was worried id has to be globally unique.

[please use gerrit instead, 2017-03-27 15:43:59]

Let me know when you'd like a full review.

[rwlbuis, 2017-03-27 15:49:39]

On 2017/03/27 15:43:59, ಠ_ಠ wrote:
> Let me know when you'd like a full review.

I think it is ready. Except if you need a test I guess I can work on that first.
JS specifies PaymentDetailsInit.id -> PaymentResponse returns same id? If so
Java or JS test?

[please use gerrit instead, 2017-03-27 15:50:49]

On 2017/03/27 15:49:39, rwlbuis wrote:
> JS specifies PaymentDetailsInit.id -> PaymentResponse returns same id? If so
> Java or JS test?

Please write a Java test. The Java is necessary to drive the UI.

[please use gerrit instead, 2017-03-27 15:52:49]

Please send out an intent-to-implement-and-ship to blink-dev@chromium.org. See
instructions at https://www.chromium.org/blink/launching-features. Then link to
your post from the CL description.

[please use gerrit instead, 2017-03-27 16:22:37]

https://codereview.chromium.org/2770193003/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://codereview.chromium.org/2770193003/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:298:
private String mId;
Make this final and move it to the block of final variables. For example, line
263.

https://codereview.chromium.org/2770193003/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:763:
if (details.id != null) {
"id" can be set only in init(). It should not be set in updateWith(). Both of
those functions call into parseAndValidateDetailsOrDisconnectFromClient().
Therefore, this function is not the appropriate place for copying the "id".
Let's move the copying into init() instead.

If the response to https://github.com/w3c/browser-payment-api/issues/483 is
"generate `id` when it's empty or null," then init() should also check that
`details.id` is not null and not empty.

https://codereview.chromium.org/2770193003/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:1175:
mId, selectedShippingAddress, selectedShippingOption, selectedContact, this);
No need to pass `mId` back into the renderer. The renderer process already has
the identifier, which is unchangeable after construction.

https://codereview.chromium.org/2770193003/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentResponseHelper.java
(right):

https://codereview.chromium.org/2770193003/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentResponseHelper.java:43:
public PaymentResponseHelper(String requestId, PaymentOption
selectedShippingAddress,
No need.

https://codereview.chromium.org/2770193003/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentResponseHelper.java:48:
mPaymentResponse.requestId = requestId;
No need.

https://codereview.chromium.org/2770193003/diff/120001/components/payments/co...
File components/payments/content/payment_request.mojom (right):

https://codereview.chromium.org/2770193003/diff/120001/components/payments/co...
components/payments/content/payment_request.mojom:67: string requestId;
The string is never modified inside of the browser process, so no need to send
it back to the renderer process.

https://codereview.chromium.org/2770193003/diff/120001/components/payments/co...
components/payments/content/payment_request.mojom:192: string? id;
Add a comment about where this string comes from and how it's going to be used.

https://codereview.chromium.org/2770193003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right):

https://codereview.chromium.org/2770193003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:525: if
(!input.id().isEmpty())
The spec says non-normatively:

"If an id member is not present, then the user agent will generate a unique
identifier for the payment request during construction."

There's no normative algorithm. I've filed
https://github.com/w3c/browser-payment-api/issues/483 to request clarification
here. In the meantime, let's use "input.hasId()" instead of
"input.id().isEmpty()".

https://codereview.chromium.org/2770193003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:989:
m_showResolver->resolve(new PaymentResponse(std::move(response), this));
Please pass the "mId" member into the "new PaymentResponse()" constructor.

https://codereview.chromium.org/2770193003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/payments/PaymentResponse.cpp (right):

https://codereview.chromium.org/2770193003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/payments/PaymentResponse.cpp:18: :
m_requestId(response->requestId),
Use the "id" from the PaymentRequest in the renderer instead.

https://codereview.chromium.org/2770193003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/payments/PaymentResponse.h (right):

https://codereview.chromium.org/2770193003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/payments/PaymentResponse.h:32:
PaymentResponse(payments::mojom::blink::PaymentResponsePtr,
Pass the "id" into this constructor, please.

[rwlbuis, 2017-03-27 20:43:29]

On 2017/03/27 15:50:49, ಠ_ಠ wrote:
> On 2017/03/27 15:49:39, rwlbuis wrote:
> > JS specifies PaymentDetailsInit.id -> PaymentResponse returns same id? If so
> > Java or JS test?
> 
> Please write a Java test. The Java is necessary to drive the UI.

Done plus a C++ unit test.

[rwlbuis, 2017-03-27 20:45:30]

https://codereview.chromium.org/2770193003/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://codereview.chromium.org/2770193003/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:298:
private String mId;
On 2017/03/27 16:22:36, ಠ_ಠ wrote:
> Make this final and move it to the block of final variables. For example, line
> 263.

I dont think I can make it final.

https://codereview.chromium.org/2770193003/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:763:
if (details.id != null) {
On 2017/03/27 16:22:36, ಠ_ಠ wrote:
> "id" can be set only in init(). It should not be set in updateWith(). Both of
> those functions call into parseAndValidateDetailsOrDisconnectFromClient().
> Therefore, this function is not the appropriate place for copying the "id".
> Let's move the copying into init() instead.
> 
> If the response to https://github.com/w3c/browser-payment-api/issues/483 is
> "generate `id` when it's empty or null," then init() should also check that
> `details.id` is not null and not empty.

Done.

https://codereview.chromium.org/2770193003/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:1175:
mId, selectedShippingAddress, selectedShippingOption, selectedContact, this);
On 2017/03/27 16:22:36, ಠ_ಠ wrote:
> No need to pass `mId` back into the renderer. The renderer process already has
> the identifier, which is unchangeable after construction.

Done.

https://codereview.chromium.org/2770193003/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentResponseHelper.java
(right):

https://codereview.chromium.org/2770193003/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentResponseHelper.java:43:
public PaymentResponseHelper(String requestId, PaymentOption
selectedShippingAddress,
On 2017/03/27 16:22:36, ಠ_ಠ wrote:
> No need.

Done.

https://codereview.chromium.org/2770193003/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentResponseHelper.java:48:
mPaymentResponse.requestId = requestId;
On 2017/03/27 16:22:36, ಠ_ಠ wrote:
> No need.

Done.

https://codereview.chromium.org/2770193003/diff/120001/components/payments/co...
File components/payments/content/payment_request.mojom (right):

https://codereview.chromium.org/2770193003/diff/120001/components/payments/co...
components/payments/content/payment_request.mojom:67: string requestId;
On 2017/03/27 16:22:36, ಠ_ಠ wrote:
> The string is never modified inside of the browser process, so no need to send
> it back to the renderer process.

Done.

https://codereview.chromium.org/2770193003/diff/120001/components/payments/co...
components/payments/content/payment_request.mojom:192: string? id;
On 2017/03/27 16:22:36, ಠ_ಠ wrote:
> Add a comment about where this string comes from and how it's going to be
used.

Done.

https://codereview.chromium.org/2770193003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right):

https://codereview.chromium.org/2770193003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:525: if
(!input.id().isEmpty())
On 2017/03/27 16:22:36, ಠ_ಠ wrote:
> The spec says non-normatively:
> 
> "If an id member is not present, then the user agent will generate a unique
> identifier for the payment request during construction."
> 
> There's no normative algorithm. I've filed
> https://github.com/w3c/browser-payment-api/issues/483 to request clarification
> here. In the meantime, let's use "input.hasId()" instead of
> "input.id().isEmpty()".

Done.

https://codereview.chromium.org/2770193003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:989:
m_showResolver->resolve(new PaymentResponse(std::move(response), this));
On 2017/03/27 16:22:36, ಠ_ಠ wrote:
> Please pass the "mId" member into the "new PaymentResponse()" constructor.

Done.

https://codereview.chromium.org/2770193003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/payments/PaymentResponse.cpp (right):

https://codereview.chromium.org/2770193003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/payments/PaymentResponse.cpp:18: :
m_requestId(response->requestId),
On 2017/03/27 16:22:36, ಠ_ಠ wrote:
> Use the "id" from the PaymentRequest in the renderer instead.

Done.

https://codereview.chromium.org/2770193003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/payments/PaymentResponse.h (right):

https://codereview.chromium.org/2770193003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/payments/PaymentResponse.h:32:
PaymentResponse(payments::mojom::blink::PaymentResponsePtr,
On 2017/03/27 16:22:36, ಠ_ಠ wrote:
> Pass the "id" into this constructor, please.

Done.

[please use gerrit instead, 2017-03-27 21:16:05]

LGTM % comments. Remember to file an intent to implement and ship before landing
this.

https://codereview.chromium.org/2770193003/diff/160001/chrome/test/data/payme...
File chrome/test/data/payments/payment_request_id.js (right):

https://codereview.chromium.org/2770193003/diff/160001/chrome/test/data/payme...
chrome/test/data/payments/payment_request_id.js:7: /* global
PaymentRequest:false */
No longer necessary, because latest linters are aware of existence of
PaymentRequest.

https://codereview.chromium.org/2770193003/diff/160001/chrome/test/data/payme...
chrome/test/data/payments/payment_request_id.js:9: var request;
Not necessary.

https://codereview.chromium.org/2770193003/diff/160001/chrome/test/data/payme...
File chrome/test/data/payments/payment_request_id_test.html (right):

https://codereview.chromium.org/2770193003/diff/160001/chrome/test/data/payme...
chrome/test/data/payments/payment_request_id_test.html:9: <title>Contact Details
Test</title>
Update the title please.

https://codereview.chromium.org/2770193003/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/payments/PaymentResponse.h (right):

https://codereview.chromium.org/2770193003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/payments/PaymentResponse.h:34: const String&
requestId = "");
= "" would only be used in tests. I prefer to avoid test-only code in
production. Therefore, please make the |requestId| parameter required.

[rwlbuis, 2017-03-28 13:44:01]

Description was changed from

==========
Implement requestId in PaymentDetails

Implement requestId in PaymentDetails as well as id
getter in PaymentRequest.

In order for this functionality to make sense we pass the
id to the payment app and make sure to set it in the
PaymentResponse being sent back to the renderer.

BUG=701254
==========

to

==========
Implement request id in PaymentDetailsInit

Implement request id in PaymentDetailsInit as well as id
getter in PaymentRequest.

In order for this functionality to make sense we pass the
id to the payment app and make sure to set it in the
PaymentResponse through the requestId attribute.

BUG=701254
==========

[rwlbuis, 2017-03-28 14:33:48]

Patchset #7 (id:180001) has been deleted

[rwlbuis, 2017-03-28 15:34:49]

Description was changed from

==========
Implement request id in PaymentDetailsInit

Implement request id in PaymentDetailsInit as well as id
getter in PaymentRequest.

In order for this functionality to make sense we pass the
id to the payment app and make sure to set it in the
PaymentResponse through the requestId attribute.

BUG=701254
==========

to

==========
Implement request id in PaymentDetailsInit

Implement request id in PaymentDetailsInit as well as id
getter in PaymentRequest.

In order for this functionality to make sense we pass the
id to the payment app and make sure to set it in the
PaymentResponse through the requestId attribute.

Intent to Implement and Ship thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/WaHAg3wh7jw

BUG=701254
==========

[rwlbuis, 2017-03-28 16:39:58]

Patchset #8 (id:220001) has been deleted

[please use gerrit instead, 2017-03-28 16:43:01]

Please put a link to the blink-dev intent in the CL description:

https://groups.google.com/a/chromium.org/d/msg/blink-dev/WaHAg3wh7jw/vWAqxSnO...

[rwlbuis, 2017-03-28 17:45:34]

Description was changed from

==========
Implement request id in PaymentDetailsInit

Implement request id in PaymentDetailsInit as well as id
getter in PaymentRequest.

In order for this functionality to make sense we pass the
id to the payment app and make sure to set it in the
PaymentResponse through the requestId attribute.

Intent to Implement and Ship thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/WaHAg3wh7jw

BUG=701254
==========

to

==========
Implement request id in PaymentDetailsInit

Implement request id in PaymentDetailsInit as well as id
getter in PaymentRequest.

In order for this functionality to make sense we pass the
id to the payment app and make sure to set it in the
PaymentResponse through the requestId attribute.

Intent to Implement and Ship thread:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/WaHAg3wh7jw/vW...

BUG=701254
==========

[rwlbuis, 2017-03-28 17:45:52]

On 2017/03/28 16:43:01, ಠ_ಠ wrote:
> Please put a link to the blink-dev intent in the CL description:
> 
>
https://groups.google.com/a/chromium.org/d/msg/blink-dev/WaHAg3wh7jw/vWAqxSnO...

Done! Waiting for the dependent patch to land...

[rwlbuis, 2017-03-28 17:45:53]

On 2017/03/28 16:43:01, ಠ_ಠ wrote:
> Please put a link to the blink-dev intent in the CL description:
> 
>
https://groups.google.com/a/chromium.org/d/msg/blink-dev/WaHAg3wh7jw/vWAqxSnO...

Done! Waiting for the dependent patch to land...

[rwlbuis, 2017-03-29 11:43:04]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2017-03-29 11:43:05]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2770193003/#ps240001
(title: "Depend on reland patch")

[commit-bot: I haz the power, 2017-03-29 11:43:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 11:50:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 11:50:26]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[please use gerrit instead, 2017-03-29 13:25:17]

Need to wait for three L-G-T-M-s on the "request to implement and ship" before
committing this, by the way.

[rwlbuis, 2017-03-29 15:46:20]

On 2017/03/29 13:25:17, ಠ_ಠ wrote:
> Need to wait for three L-G-T-M-s on the "request to implement and ship" before
> committing this, by the way.

Thanks, was wondering about that. In the mean time I'll make this show up
green...

[rwlbuis, 2017-03-30 01:31:56]

rob.buis@samsung.com changed reviewers:
+ tsepez@chromium.org

[rwlbuis, 2017-03-30 01:31:57]

+Tom Sepez for mojom change.

[Tom Sepez, 2017-03-30 16:44:03]

lgtm

[rwlbuis, 2017-03-30 17:37:58]

Description was changed from

==========
Implement request id in PaymentDetailsInit

Implement request id in PaymentDetailsInit as well as id
getter in PaymentRequest.

In order for this functionality to make sense we pass the
id to the payment app and make sure to set it in the
PaymentResponse through the requestId attribute.

Intent to Implement and Ship thread:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/WaHAg3wh7jw/vW...

BUG=701254
==========

to

==========
Implement request id in PaymentDetailsInit

Implement request id in PaymentDetailsInit as well as id
getter in PaymentRequest.

In order for this functionality to make sense we pass the
id to the payment app and make sure to set it in the
PaymentResponse through the requestId attribute.

Added PaymentRequestIdTest as a payment integration test for verifying
the PaymentResponse contains the free-form identifier specified in
PaymentDetailsInit

Added PaymentRequestTest.DetailsIdIsSet unit test to verify that
PaymentDetailsInit.id
is reflected in PaymentRequest.id.

Intent to Implement and Ship thread:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/WaHAg3wh7jw/vW...

BUG=701254
TEST=PaymentRequestIdTest, DetailsIdIsSet
==========

[rwlbuis, 2017-04-11 19:47:07]

Patchset #11 (id:300001) has been deleted

[rwlbuis, 2017-04-12 18:09:44]

Description was changed from

==========
Implement request id in PaymentDetailsInit

Implement request id in PaymentDetailsInit as well as id
getter in PaymentRequest.

In order for this functionality to make sense we pass the
id to the payment app and make sure to set it in the
PaymentResponse through the requestId attribute.

Added PaymentRequestIdTest as a payment integration test for verifying
the PaymentResponse contains the free-form identifier specified in
PaymentDetailsInit

Added PaymentRequestTest.DetailsIdIsSet unit test to verify that
PaymentDetailsInit.id
is reflected in PaymentRequest.id.

Intent to Implement and Ship thread:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/WaHAg3wh7jw/vW...

BUG=701254
TEST=PaymentRequestIdTest, DetailsIdIsSet
==========

to

==========
Implement request id in PaymentDetailsInit

Implement request id in PaymentDetailsInit as well as id
getter in PaymentRequest.

In order for this functionality to make sense we pass the
id to the payment app and make sure to set it in the
PaymentResponse through the requestId attribute.

Added PaymentRequestIdTest as a payment integration test for verifying
the PaymentResponse contains the free-form identifier specified in
PaymentDetailsInit.

Added PaymentRequestTest.DetailsIdIsSet unit test to verify that
PaymentDetailsInit.id
is reflected in PaymentRequest.id.

Added external/wpt/payment-request/payment-request-id.html to test that
PaymentDetailsInit.id
is reflected in PaymentRequest.id and that not providing an id generates a UUID.

Added a manual test
external/wpt/payment-request/payment-request-response-id.html for verifying
the PaymentResponse contains the free-form identifier specified in
PaymentDetailsInit.

Intent to Implement and Ship thread:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/WaHAg3wh7jw/vW...

BUG=701254
TEST=PaymentRequestIdTest, DetailsIdIsSet
==========

[rwlbuis, 2017-04-12 21:43:49]

Patchset #16 (id:420001) has been deleted

[rwlbuis, 2017-04-12 23:19:24]

Patchset #16 (id:440001) has been deleted

[rwlbuis, 2017-04-13 01:08:11]

Patchset #16 (id:460001) has been deleted

[rwlbuis, 2017-04-13 02:03:52]

Patchset #16 (id:480001) has been deleted

[rwlbuis, 2017-04-13 12:28:38]

Patchset #16 (id:490001) has been deleted

[rwlbuis, 2017-04-13 14:00:30]

Description was changed from

==========
Implement request id in PaymentDetailsInit

Implement request id in PaymentDetailsInit as well as id
getter in PaymentRequest.

In order for this functionality to make sense we pass the
id to the payment app and make sure to set it in the
PaymentResponse through the requestId attribute.

Added PaymentRequestIdTest as a payment integration test for verifying
the PaymentResponse contains the free-form identifier specified in
PaymentDetailsInit.

Added PaymentRequestTest.DetailsIdIsSet unit test to verify that
PaymentDetailsInit.id
is reflected in PaymentRequest.id.

Added external/wpt/payment-request/payment-request-id.html to test that
PaymentDetailsInit.id
is reflected in PaymentRequest.id and that not providing an id generates a UUID.

Added a manual test
external/wpt/payment-request/payment-request-response-id.html for verifying
the PaymentResponse contains the free-form identifier specified in
PaymentDetailsInit.

Intent to Implement and Ship thread:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/WaHAg3wh7jw/vW...

BUG=701254
TEST=PaymentRequestIdTest, DetailsIdIsSet
==========

to

==========
Implement request id in PaymentDetailsInit

Implement request id in PaymentDetailsInit as well as id
getter in PaymentRequest.

In order for this functionality to make sense we pass the
id to the payment app and make sure to set it in the
PaymentResponse through the requestId attribute.

Added PaymentRequestIdTest as a payment integration test for verifying
the PaymentResponse contains the free-form identifier specified in
PaymentDetailsInit.

Added PaymentRequestTest.DetailsIdIsSet unit test to verify that
PaymentDetailsInit.id
is reflected in PaymentRequest.id.

Added external/wpt/payment-request/payment-request-id.https.html to test that
PaymentDetailsInit.id
is reflected in PaymentRequest.id and that not providing an id generates a UUID.

Added a manual test
external/wpt/payment-request/payment-request-response-id.html for verifying
the PaymentResponse contains the free-form identifier specified in
PaymentDetailsInit.

Intent to Implement and Ship thread:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/WaHAg3wh7jw/vW...

BUG=701254
TEST=PaymentRequestIdTest, DetailsIdIsSet
==========

[rwlbuis, 2017-04-27 20:03:02]

Description was changed from

==========
Implement request id in PaymentDetailsInit

Implement request id in PaymentDetailsInit as well as id
getter in PaymentRequest.

In order for this functionality to make sense we pass the
id to the payment app and make sure to set it in the
PaymentResponse through the requestId attribute.

Added PaymentRequestIdTest as a payment integration test for verifying
the PaymentResponse contains the free-form identifier specified in
PaymentDetailsInit.

Added PaymentRequestTest.DetailsIdIsSet unit test to verify that
PaymentDetailsInit.id
is reflected in PaymentRequest.id.

Added external/wpt/payment-request/payment-request-id.https.html to test that
PaymentDetailsInit.id
is reflected in PaymentRequest.id and that not providing an id generates a UUID.

Added a manual test
external/wpt/payment-request/payment-request-response-id.html for verifying
the PaymentResponse contains the free-form identifier specified in
PaymentDetailsInit.

Intent to Implement and Ship thread:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/WaHAg3wh7jw/vW...

BUG=701254
TEST=PaymentRequestIdTest, DetailsIdIsSet
==========

to

==========
Implement request id in PaymentDetailsInit

Implement request id in PaymentDetailsInit as well as id
getter in PaymentRequest.

In order for this functionality to make sense we pass the
id to the payment app and make sure to set it in the
PaymentResponse through the requestId attribute.

Added PaymentRequestIdTest as a payment integration test for verifying
the PaymentResponse contains the free-form identifier specified in
PaymentDetailsInit.

Added PaymentRequestTest.DetailsIdIsSet unit test to verify that
PaymentDetailsInit.id is reflected in PaymentRequest.id.

Added external/wpt/payment-request/payment-request-id.https.html to test that
PaymentDetailsInit.id is reflected in PaymentRequest.id and that not providing
an id generates a UUID.

Added manual test external/wpt/payment-request/payment-request-response-id.html
for verifying the PaymentResponse contains the free-form identifier specified
in PaymentDetailsInit.

Intent to Implement and Ship thread:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/WaHAg3wh7jw/vW...

BUG=701254
TEST=PaymentRequestIdTest, DetailsIdIsSet
==========

[rwlbuis, 2017-04-27 20:30:26]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2017-04-27 20:30:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
rouslan@chromium.org, tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2770193003/#ps550001
(title: "Rebase once more since mojom file moved")

[commit-bot: I haz the power, 2017-04-27 20:31:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 20:48:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 20:48:36]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rwlbuis, 2017-04-27 21:38:35]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2017-04-27 21:39:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 22:51:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 22:51:02]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rwlbuis, 2017-04-28 01:30:29]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2017-04-28 01:33:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 02:53:39]

CQ is committing da patch.

Bot data: {"patchset_id": 550001, "attempt_start_ts": 1493343029545250,
"parent_rev": "887765826710c2b0708b5a1e003fc868c294c0dd", "commit_rev":
"c538713fa88d7fb0a831fbaa3b7dedafb9b5cdbf"}

[commit-bot: I haz the power, 2017-04-28 02:53:51]

Description was changed from

==========
Implement request id in PaymentDetailsInit

Implement request id in PaymentDetailsInit as well as id
getter in PaymentRequest.

In order for this functionality to make sense we pass the
id to the payment app and make sure to set it in the
PaymentResponse through the requestId attribute.

Added PaymentRequestIdTest as a payment integration test for verifying
the PaymentResponse contains the free-form identifier specified in
PaymentDetailsInit.

Added PaymentRequestTest.DetailsIdIsSet unit test to verify that
PaymentDetailsInit.id is reflected in PaymentRequest.id.

Added external/wpt/payment-request/payment-request-id.https.html to test that
PaymentDetailsInit.id is reflected in PaymentRequest.id and that not providing
an id generates a UUID.

Added manual test external/wpt/payment-request/payment-request-response-id.html
for verifying the PaymentResponse contains the free-form identifier specified
in PaymentDetailsInit.

Intent to Implement and Ship thread:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/WaHAg3wh7jw/vW...

BUG=701254
TEST=PaymentRequestIdTest, DetailsIdIsSet
==========

to

==========
Implement request id in PaymentDetailsInit

Implement request id in PaymentDetailsInit as well as id
getter in PaymentRequest.

In order for this functionality to make sense we pass the
id to the payment app and make sure to set it in the
PaymentResponse through the requestId attribute.

Added PaymentRequestIdTest as a payment integration test for verifying
the PaymentResponse contains the free-form identifier specified in
PaymentDetailsInit.

Added PaymentRequestTest.DetailsIdIsSet unit test to verify that
PaymentDetailsInit.id is reflected in PaymentRequest.id.

Added external/wpt/payment-request/payment-request-id.https.html to test that
PaymentDetailsInit.id is reflected in PaymentRequest.id and that not providing
an id generates a UUID.

Added manual test external/wpt/payment-request/payment-request-response-id.html
for verifying the PaymentResponse contains the free-form identifier specified
in PaymentDetailsInit.

Intent to Implement and Ship thread:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/WaHAg3wh7jw/vW...

BUG=701254
TEST=PaymentRequestIdTest, DetailsIdIsSet

Review-Url: https://codereview.chromium.org/2770193003
Cr-Commit-Position: refs/heads/master@{#467854}
Committed:
https://chromium.googlesource.com/chromium/src/+/c538713fa88d7fb0a831fbaa3b7d...
==========

[commit-bot: I haz the power, 2017-04-28 02:53:52]

Committed patchset #18 (id:550001) as
https://chromium.googlesource.com/chromium/src/+/c538713fa88d7fb0a831fbaa3b7d...