Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

Issue 2770193003: Implement request id in PaymentDetailsInit (Closed)
Patch Set: Rebase once more since mojom file moved Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp b/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
index 379ecc98cce6ebb167e5e49133fbaef1acbe0479..f28abe365e23bd005c35ae66b6d34536c944d1db 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
@@ -15,8 +15,10 @@ namespace blink {
PaymentResponse::PaymentResponse(
payments::mojom::blink::PaymentResponsePtr response,
- PaymentCompleter* payment_completer)
- : method_name_(response->method_name),
+ PaymentCompleter* payment_completer,
+ const String& requestId)
+ : requestId_(requestId),
+ method_name_(response->method_name),
stringified_details_(response->stringified_details),
shipping_address_(
response->shipping_address
@@ -34,6 +36,7 @@ PaymentResponse::~PaymentResponse() {}
ScriptValue PaymentResponse::toJSONForBinding(ScriptState* script_state) const {
V8ObjectBuilder result(script_state);
+ result.AddString("requestId", requestId());
result.AddString("methodName", methodName());
result.Add("details", details(script_state, ASSERT_NO_EXCEPTION));

Powered by Google App Engine
This is Rietveld 408576698