Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2770083004: Make HostResolverImpl log resolved addresses when reading from cache or hosts file (Closed)

Created:
3 years, 9 months ago by mgersh
Modified:
3 years, 8 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, eroman, mmenke, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make HostResolverImpl log resolved addresses when reading from cache or hosts file Review-Url: https://codereview.chromium.org/2770083004 Cr-Commit-Position: refs/heads/master@{#460518} Committed: https://chromium.googlesource.com/chromium/src/+/33d23c0dee81811025d61eb8ef325c867e66bafe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M net/dns/host_resolver_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/log/net_log_event_type_list.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mgersh
3 years, 9 months ago (2017-03-24 21:37:43 UTC) #2
mgersh
Ping on this one too
3 years, 8 months ago (2017-03-29 18:15:55 UTC) #3
eroman
lgtm
3 years, 8 months ago (2017-03-29 18:18:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770083004/1
3 years, 8 months ago (2017-03-29 18:19:48 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 20:25:16 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/33d23c0dee81811025d61eb8ef32...

Powered by Google App Engine
This is Rietveld 408576698