Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: net/dns/host_resolver_impl.cc

Issue 2770083004: Make HostResolverImpl log resolved addresses when reading from cache or hosts file (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/log/net_log_event_type_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/dns/host_resolver_impl.cc
diff --git a/net/dns/host_resolver_impl.cc b/net/dns/host_resolver_impl.cc
index 31e535d0efa3c4a24e277068d7f34856be9361f4..cd38b0fb4e6c3de6d9e3fd2a6a43253f500f70a2 100644
--- a/net/dns/host_resolver_impl.cc
+++ b/net/dns/host_resolver_impl.cc
@@ -2156,7 +2156,8 @@ int HostResolverImpl::ResolveHelper(const Key& key,
}
if (ServeFromCache(key, info, &net_error, addresses, allow_stale,
stale_info)) {
- source_net_log.AddEvent(NetLogEventType::HOST_RESOLVER_IMPL_CACHE_HIT);
+ source_net_log.AddEvent(NetLogEventType::HOST_RESOLVER_IMPL_CACHE_HIT,
+ addresses->CreateNetLogCallback());
// |ServeFromCache()| will set |*stale_info| as needed.
RunCacheHitCallbacks(key, info);
return net_error;
@@ -2164,7 +2165,8 @@ int HostResolverImpl::ResolveHelper(const Key& key,
// TODO(szym): Do not do this if nsswitch.conf instructs not to.
// http://crbug.com/117655
if (ServeFromHosts(key, info, addresses)) {
- source_net_log.AddEvent(NetLogEventType::HOST_RESOLVER_IMPL_HOSTS_HIT);
+ source_net_log.AddEvent(NetLogEventType::HOST_RESOLVER_IMPL_HOSTS_HIT,
+ addresses->CreateNetLogCallback());
MakeNotStale(stale_info);
return OK;
}
« no previous file with comments | « no previous file | net/log/net_log_event_type_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698