Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2769963002: Disable 4 reading list tests. (Closed)

Created:
3 years, 9 months ago by baxley
Modified:
3 years, 9 months ago
Reviewers:
jif, edchin, lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, stkhapugin, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable 4 reading list tests. Several reading list tests to test visibility of buttons are failing on every platform. BUG=704401 TBR=jif Review-Url: https://codereview.chromium.org/2769963002 Cr-Commit-Position: refs/heads/master@{#459001} Committed: https://chromium.googlesource.com/chromium/src/+/533f43506d597e4f761832fea3e5e4078a8b7c60

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M ios/chrome/browser/ui/reading_list/reading_list_egtest.mm View 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
baxley
jif, edchin as sheriffs lpromero in case this is due to MDC
3 years, 9 months ago (2017-03-23 04:08:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769963002/1
3 years, 9 months ago (2017-03-23 04:09:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/533f43506d597e4f761832fea3e5e4078a8b7c60
3 years, 9 months ago (2017-03-23 04:20:39 UTC) #8
jif
lgtm
3 years, 9 months ago (2017-03-23 08:43:28 UTC) #9
lpromero
3 years, 9 months ago (2017-03-23 09:29:20 UTC) #10
Message was sent while issue was closed.
lgtm, the breakage is due to my commit in MDC:
https://github.com/material-components/material-components-ios/commit/4cbdfb9...

I think it would have been safe to revert the roll and pause the autoroller too.

Mike, can we move more tests to the upstream CQ and waterfall?

Powered by Google App Engine
This is Rietveld 408576698