Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: ios/chrome/browser/ui/reading_list/reading_list_egtest.mm

Issue 2769963002: Disable 4 reading list tests. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <EarlGrey/EarlGrey.h> 5 #import <EarlGrey/EarlGrey.h>
6 #import <UIKit/UIKit.h> 6 #import <UIKit/UIKit.h>
7 #import <XCTest/XCTest.h> 7 #import <XCTest/XCTest.h>
8 8
9 #include "base/strings/sys_string_conversions.h" 9 #include "base/strings/sys_string_conversions.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 331 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_READ_BUTTON); 342 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_READ_BUTTON);
343 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_UNREAD_BUTTON); 343 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_UNREAD_BUTTON);
344 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_ALL_BUTTON); 344 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_ALL_BUTTON);
345 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_BUTTON); 345 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_BUTTON);
346 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_CANCEL_BUTTON); 346 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_CANCEL_BUTTON);
347 AssertButtonVisibleWithID(IDS_IOS_READING_LIST_EDIT_BUTTON); 347 AssertButtonVisibleWithID(IDS_IOS_READING_LIST_EDIT_BUTTON);
348 } 348 }
349 349
350 // Tests that only the "Cancel", "Delete All Read" and "Mark All…" buttons are 350 // Tests that only the "Cancel", "Delete All Read" and "Mark All…" buttons are
351 // showing when not editing. 351 // showing when not editing.
352 - (void)testVisibleButtonsEditingModeEmptySelection { 352 // TODO(crbug.com/704401): Re-enable this test.
353 - (void)DISABLED_testVisibleButtonsEditingModeEmptySelection {
353 AddEntriesAndEnterEdit(); 354 AddEntriesAndEnterEdit();
354 355
355 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_DELETE_BUTTON); 356 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_DELETE_BUTTON);
356 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_READ_BUTTON); 357 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_READ_BUTTON);
357 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_UNREAD_BUTTON); 358 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_UNREAD_BUTTON);
358 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_BUTTON); 359 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_BUTTON);
359 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_EDIT_BUTTON); 360 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_EDIT_BUTTON);
360 AssertButtonVisibleWithID(IDS_IOS_READING_LIST_DELETE_ALL_READ_BUTTON); 361 AssertButtonVisibleWithID(IDS_IOS_READING_LIST_DELETE_ALL_READ_BUTTON);
361 AssertButtonVisibleWithID(IDS_IOS_READING_LIST_MARK_ALL_BUTTON); 362 AssertButtonVisibleWithID(IDS_IOS_READING_LIST_MARK_ALL_BUTTON);
362 AssertButtonVisibleWithID(IDS_IOS_READING_LIST_CANCEL_BUTTON); 363 AssertButtonVisibleWithID(IDS_IOS_READING_LIST_CANCEL_BUTTON);
363 } 364 }
364 365
365 // Tests that only the "Cancel", "Delete" and "Mark Unread" buttons are showing 366 // Tests that only the "Cancel", "Delete" and "Mark Unread" buttons are showing
366 // when not editing. 367 // when not editing.
367 - (void)testVisibleButtonsOnlyReadEntrySelected { 368 // TODO(crbug.com/704401): Re-enable this test.
369 - (void)DISABLED_testVisibleButtonsOnlyReadEntrySelected {
368 AddEntriesAndEnterEdit(); 370 AddEntriesAndEnterEdit();
369 TapEntry(kReadTitle); 371 TapEntry(kReadTitle);
370 372
371 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_DELETE_ALL_READ_BUTTON); 373 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_DELETE_ALL_READ_BUTTON);
372 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_READ_BUTTON); 374 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_READ_BUTTON);
373 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_BUTTON); 375 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_BUTTON);
374 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_EDIT_BUTTON); 376 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_EDIT_BUTTON);
375 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_ALL_BUTTON); 377 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_ALL_BUTTON);
376 AssertButtonVisibleWithID(IDS_IOS_READING_LIST_MARK_UNREAD_BUTTON); 378 AssertButtonVisibleWithID(IDS_IOS_READING_LIST_MARK_UNREAD_BUTTON);
377 AssertButtonVisibleWithID(IDS_IOS_READING_LIST_DELETE_BUTTON); 379 AssertButtonVisibleWithID(IDS_IOS_READING_LIST_DELETE_BUTTON);
378 AssertButtonVisibleWithID(IDS_IOS_READING_LIST_CANCEL_BUTTON); 380 AssertButtonVisibleWithID(IDS_IOS_READING_LIST_CANCEL_BUTTON);
379 } 381 }
380 382
381 // Tests that only the "Cancel", "Delete" and "Mark Read" buttons are showing 383 // Tests that only the "Cancel", "Delete" and "Mark Read" buttons are showing
382 // when not editing. 384 // when not editing.
383 - (void)testVisibleButtonsOnlyUnreadEntrySelected { 385 // TODO(crbug.com/704401): Re-enable this test.
386 - (void)DISABLED_testVisibleButtonsOnlyUnreadEntrySelected {
384 AddEntriesAndEnterEdit(); 387 AddEntriesAndEnterEdit();
385 TapEntry(kUnreadTitle); 388 TapEntry(kUnreadTitle);
386 389
387 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_DELETE_ALL_READ_BUTTON); 390 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_DELETE_ALL_READ_BUTTON);
388 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_UNREAD_BUTTON); 391 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_UNREAD_BUTTON);
389 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_BUTTON); 392 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_BUTTON);
390 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_EDIT_BUTTON); 393 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_EDIT_BUTTON);
391 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_ALL_BUTTON); 394 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_ALL_BUTTON);
392 AssertButtonVisibleWithID(IDS_IOS_READING_LIST_MARK_READ_BUTTON); 395 AssertButtonVisibleWithID(IDS_IOS_READING_LIST_MARK_READ_BUTTON);
393 AssertButtonVisibleWithID(IDS_IOS_READING_LIST_DELETE_BUTTON); 396 AssertButtonVisibleWithID(IDS_IOS_READING_LIST_DELETE_BUTTON);
394 AssertButtonVisibleWithID(IDS_IOS_READING_LIST_CANCEL_BUTTON); 397 AssertButtonVisibleWithID(IDS_IOS_READING_LIST_CANCEL_BUTTON);
395 } 398 }
396 399
397 // Tests that only the "Cancel", "Delete" and "Mark…" buttons are showing when 400 // Tests that only the "Cancel", "Delete" and "Mark…" buttons are showing when
398 // not editing. 401 // not editing.
399 - (void)testVisibleButtonsMixedEntriesSelected { 402 // TODO(crbug.com/704401): Re-enable this test.
403 - (void)DISABLED_testVisibleButtonsMixedEntriesSelected {
400 AddEntriesAndEnterEdit(); 404 AddEntriesAndEnterEdit();
401 TapEntry(kReadTitle); 405 TapEntry(kReadTitle);
402 TapEntry(kUnreadTitle); 406 TapEntry(kUnreadTitle);
403 407
404 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_DELETE_ALL_READ_BUTTON); 408 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_DELETE_ALL_READ_BUTTON);
405 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_UNREAD_BUTTON); 409 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_UNREAD_BUTTON);
406 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_READ_BUTTON); 410 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_READ_BUTTON);
407 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_EDIT_BUTTON); 411 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_EDIT_BUTTON);
408 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_ALL_BUTTON); 412 AssertButtonNotVisibleWithID(IDS_IOS_READING_LIST_MARK_ALL_BUTTON);
409 AssertButtonVisibleWithID(IDS_IOS_READING_LIST_MARK_BUTTON); 413 AssertButtonVisibleWithID(IDS_IOS_READING_LIST_MARK_BUTTON);
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
553 assertWithMatcher:grey_nil()]; 557 assertWithMatcher:grey_nil()];
554 TapButtonWithID(IDS_IOS_READING_LIST_EDIT_BUTTON); 558 TapButtonWithID(IDS_IOS_READING_LIST_EDIT_BUTTON);
555 TapButtonWithID(IDS_IOS_READING_LIST_DELETE_ALL_READ_BUTTON); 559 TapButtonWithID(IDS_IOS_READING_LIST_DELETE_ALL_READ_BUTTON);
556 560
557 // Verify the background string is displayed. 561 // Verify the background string is displayed.
558 [[EarlGrey selectElementWithMatcher:EmptyBackground()] 562 [[EarlGrey selectElementWithMatcher:EmptyBackground()]
559 assertWithMatcher:grey_notNil()]; 563 assertWithMatcher:grey_notNil()];
560 } 564 }
561 565
562 @end 566 @end
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698