Revert of Add enable_ipc_logging build argument

Revert of Add enable_ipc_logging build argument (patchset #2 id:20001 of https://codereview.chromium.org/2770653002/ )

Reason for revert:

Findit identified CL at revision 459094 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzc2ODkwZWMxMWU3NDAyNTkxZDFjOWFkZDUzM2Q0ZTYxYzMwZjhlMDgM

Original issue's description:
> Add enable_ipc_logging build argument
> 
> Implement a build option to enable the IPC logging system
> in release builds. It's useful to save time and resources when
> debugging IPC communication (e.g. in automated testing
> environments).
> 
> It also turns IPC_MESSAGE_LOG_ENABLED macro to a build flag.
> 
> BUG=
> 
> Review-Url: https://codereview.chromium.org/2770653002
> Cr-Commit-Position: refs/heads/master@{#459094}
> Committed: https://chromium.googlesource.com/chromium/src/+/76890ec11e7402591d1c9add533d4e61c30f8e08

TBR=rockot@chromium.org,cpu@chromium.org,jam@chromium.org,kenrb@chromium.org,davidsz@inf.u-szeged.hu
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

[findit-for-me, 2017-03-23 16:30:50]

Created Revert of Add enable_ipc_logging build argument

[findit-for-me, 2017-03-23 16:30:51]

findit-for-me@appspot.gserviceaccount.com changed reviewers:
+ avi@google.com, ksakamoto@google.com, melandory@google.com, wittman@google.com

[findit-for-me, 2017-03-23 16:30:51]

Sheriffs:

Please confirm and commit this reverting CL if it is the right fix.
The original CL was identified as the culprit for failures in the build
cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[stgao, 2017-03-23 17:41:58]

On 2017/03/23 16:30:51, findit-for-me wrote:
> Sheriffs:
> 
> Please confirm and commit this reverting CL if it is the right fix.
> The original CL was identified as the culprit for failures in the build
> cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

This is a false positive due to flaky compile -- missing ipc/ipc_features.h
Will close this issue and file a bug.

[stgao, 2017-03-23 17:42:10]

Description was changed from

==========
Revert of Add enable_ipc_logging build argument (patchset #2 id:20001 of
https://codereview.chromium.org/2770653002/ )

Reason for revert:

Findit identified CL at revision 459094 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> Add enable_ipc_logging build argument
> 
> Implement a build option to enable the IPC logging system
> in release builds. It's useful to save time and resources when
> debugging IPC communication (e.g. in automated testing
> environments).
> 
> It also turns IPC_MESSAGE_LOG_ENABLED macro to a build flag.
> 
> BUG=
> 
> Review-Url: https://codereview.chromium.org/2770653002
> Cr-Commit-Position: refs/heads/master@{#459094}
> Committed:
https://chromium.googlesource.com/chromium/src/+/76890ec11e7402591d1c9add533d...

TBR=rockot@chromium.org,cpu@chromium.org,jam@chromium.org,kenrb@chromium.org,...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
==========

to

==========
Revert of Add enable_ipc_logging build argument (patchset #2 id:20001 of
https://codereview.chromium.org/2770653002/ )

Reason for revert:

Findit identified CL at revision 459094 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> Add enable_ipc_logging build argument
> 
> Implement a build option to enable the IPC logging system
> in release builds. It's useful to save time and resources when
> debugging IPC communication (e.g. in automated testing
> environments).
> 
> It also turns IPC_MESSAGE_LOG_ENABLED macro to a build flag.
> 
> BUG=
> 
> Review-Url: https://codereview.chromium.org/2770653002
> Cr-Commit-Position: refs/heads/master@{#459094}
> Committed:
https://chromium.googlesource.com/chromium/src/+/76890ec11e7402591d1c9add533d...

TBR=rockot@chromium.org,cpu@chromium.org,jam@chromium.org,kenrb@chromium.org,...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
==========

[Ken Rockot(use gerrit already), 2017-03-23 17:44:55]

On 2017/03/23 at 17:41:58, stgao wrote:
> On 2017/03/23 16:30:51, findit-for-me wrote:
> > Sheriffs:
> > 
> > Please confirm and commit this reverting CL if it is the right fix.
> > The original CL was identified as the culprit for failures in the build
> > cycles as shown on:
> >
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> 
> This is a false positive due to flaky compile -- missing ipc/ipc_features.h
> Will close this issue and file a bug.

Are you sure it's a false positive? This CL introduces that (generated) file.
It's probably legitimately a target missing a dependency on //ipc:ipc_features,
which could lead to flaky compile if the file isn't generated in time.

[Ken Rockot(use gerrit already), 2017-03-23 17:48:23]

On 2017/03/23 at 17:44:55, Ken Rockot wrote:
> On 2017/03/23 at 17:41:58, stgao wrote:
> > On 2017/03/23 16:30:51, findit-for-me wrote:
> > > Sheriffs:
> > > 
> > > Please confirm and commit this reverting CL if it is the right fix.
> > > The original CL was identified as the culprit for failures in the build
> > > cycles as shown on:
> > >
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> > 
> > This is a false positive due to flaky compile -- missing ipc/ipc_features.h
> > Will close this issue and file a bug.
> 
> Are you sure it's a false positive? This CL introduces that (generated) file.
It's probably legitimately a target missing a dependency on //ipc:ipc_features,
which could lead to flaky compile if the file isn't generated in time.

The problem is that several existing dependents on //ipc should be expressed via
public_deps rather than deps. Getting this wrong starts to matter when generated
sources are involved.

Given that the small flake here is not creating any real disruption, I'll just
land a fix to the handful of incorrect targets.

[stgao, 2017-03-23 18:51:50]

On 2017/03/23 17:48:23, Ken Rockot wrote:
> On 2017/03/23 at 17:44:55, Ken Rockot wrote:
> > On 2017/03/23 at 17:41:58, stgao wrote:
> > > On 2017/03/23 16:30:51, findit-for-me wrote:
> > > > Sheriffs:
> > > > 
> > > > Please confirm and commit this reverting CL if it is the right fix.
> > > > The original CL was identified as the culprit for failures in the build
> > > > cycles as shown on:
> > > >
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> > > 
> > > This is a false positive due to flaky compile -- missing
ipc/ipc_features.h
> > > Will close this issue and file a bug.
> > 
> > Are you sure it's a false positive? This CL introduces that (generated)
file.
> It's probably legitimately a target missing a dependency on
//ipc:ipc_features,
> which could lead to flaky compile if the file isn't generated in time.

Ah, you are right. My bad, I should search in this CL for that file first
instead of the code search.

> 
> The problem is that several existing dependents on //ipc should be expressed
via
> public_deps rather than deps. Getting this wrong starts to matter when
generated
> sources are involved.
> 
> Given that the small flake here is not creating any real disruption, I'll just
> land a fix to the handful of incorrect targets.

Thanks for looking into this!
Unfortunately, I'm not familiar with such config. It would be great if you could
help fix this.

[Ken Rockot(use gerrit already), 2017-03-23 19:05:21]

On 2017/03/23 at 18:51:50, stgao wrote:
> On 2017/03/23 17:48:23, Ken Rockot wrote:
> > On 2017/03/23 at 17:44:55, Ken Rockot wrote:
> > > On 2017/03/23 at 17:41:58, stgao wrote:
> > > > On 2017/03/23 16:30:51, findit-for-me wrote:
> > > > > Sheriffs:
> > > > > 
> > > > > Please confirm and commit this reverting CL if it is the right fix.
> > > > > The original CL was identified as the culprit for failures in the
build
> > > > > cycles as shown on:
> > > > >
> >
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> > > > 
> > > > This is a false positive due to flaky compile -- missing
ipc/ipc_features.h
> > > > Will close this issue and file a bug.
> > > 
> > > Are you sure it's a false positive? This CL introduces that (generated)
file.
> > It's probably legitimately a target missing a dependency on
//ipc:ipc_features,
> > which could lead to flaky compile if the file isn't generated in time.
> 
> Ah, you are right. My bad, I should search in this CL for that file first
instead of the code search.
> 
> > 
> > The problem is that several existing dependents on //ipc should be expressed
via
> > public_deps rather than deps. Getting this wrong starts to matter when
generated
> > sources are involved.
> > 
> > Given that the small flake here is not creating any real disruption, I'll
just
> > land a fix to the handful of incorrect targets.
> 
> Thanks for looking into this!
> Unfortunately, I'm not familiar with such config. It would be great if you
could help fix this.

https://codereview.chromium.org/2767193005 should fix it

[Ken Rockot(use gerrit already), 2017-03-23 20:13:29]

I'm going to land this revert as the change is causing more flake now. We can
reland after my dependency fix lands.

[Ken Rockot(use gerrit already), 2017-03-23 20:13:32]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2017-03-23 20:14:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 20:14:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 20:14:26]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.