Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2769703006: Reporting: Plumb into UrlRequest{HttpJob,Context}. (Closed)

Created:
3 years, 9 months ago by Julia Tuttle
Modified:
3 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reporting: Plumb into UrlRequest{HttpJob,Context}. Reporting is a spec for delivering out-of-band reports from various other parts of the browser. See http://wicg.github.io/reporting/ for the spec, or https://goo.gl/pygX5I for details of the planned implementation in Chromium. This CL adds a member in URLRequestContext{,Storage} for the ReportingService and calls ProcessHeader from URLRequestHttpJob when a Report-To header is received under the right circumstances. BUG=704259 Review-Url: https://codereview.chromium.org/2769703006 Cr-Commit-Position: refs/heads/master@{#464155} Committed: https://chromium.googlesource.com/chromium/src/+/2b8dd2d1d8c2c17e5715853ad74cf2891b3c87c7

Patch Set 1 #

Patch Set 2 : Add invalid SSL unit test case #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : Fix unittest failure. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -0 lines) Patch
M net/url_request/url_request_context.h View 1 2 3 chunks +7 lines, -0 lines 0 comments Download
M net/url_request/url_request_context.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M net/url_request/url_request_context_storage.h View 3 chunks +4 lines, -0 lines 0 comments Download
M net/url_request/url_request_context_storage.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M net/url_request/url_request_http_job.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 1 2 3 3 chunks +24 lines, -0 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 2 3 4 5 2 chunks +130 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (17 generated)
Julia Tuttle
PTAL, shivanisha.
3 years, 9 months ago (2017-03-24 16:42:03 UTC) #2
shivanisha
On 2017/03/24 at 16:42:03, juliatuttle wrote: > PTAL, shivanisha. Looking good % the ssl todo ...
3 years, 9 months ago (2017-03-24 18:47:15 UTC) #3
Julia Tuttle
PTAL, shivanisha.
3 years, 9 months ago (2017-03-27 15:09:29 UTC) #4
shivanisha
On 2017/03/27 at 15:09:29, juliatuttle wrote: > PTAL, shivanisha. lgtm
3 years, 8 months ago (2017-04-10 18:43:18 UTC) #13
Julia Tuttle
PTAL csharrison for committer signoff.
3 years, 8 months ago (2017-04-12 16:37:32 UTC) #15
Charlie Harrison
lgtm
3 years, 8 months ago (2017-04-12 16:41:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769703006/100001
3 years, 8 months ago (2017-04-12 20:08:43 UTC) #22
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 21:28:43 UTC) #25
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/2b8dd2d1d8c2c17e5715853ad74c...

Powered by Google App Engine
This is Rietveld 408576698