Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2769483002: Don't check is_ios in chrome/, it's always false there. (Closed)

Created:
3 years, 9 months ago by Nico
Modified:
3 years, 9 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, cbentzel+watch_chromium.org, arv+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't check is_ios in chrome/, it's always false there. No intended behavior change. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2769483002 Cr-Commit-Position: refs/heads/master@{#458751} Committed: https://chromium.googlesource.com/chromium/src/+/a491c34db6d1cdd8eceece02c8b5251d67c007df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -47 lines) Patch
M chrome/BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/app/resources/BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/resources/BUILD.gn View 3 chunks +20 lines, -20 lines 0 comments Download
M chrome/chrome_repack_locales.gni View 4 chunks +12 lines, -16 lines 0 comments Download
M chrome/common/features.gni View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/common/net/BUILD.gn View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 26 (19 generated)
Nico
3 years, 9 months ago (2017-03-21 21:28:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769483002/1
3 years, 9 months ago (2017-03-21 22:27:50 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 9 months ago (2017-03-21 22:27:51 UTC) #11
Nico
On 2017/03/21 22:27:51, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
3 years, 9 months ago (2017-03-21 22:30:59 UTC) #13
sdefresne
lgtm
3 years, 9 months ago (2017-03-22 09:39:27 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769483002/1
3 years, 9 months ago (2017-03-22 15:07:02 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 15:12:17 UTC) #26
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a491c34db6d1cdd8eceece02c8b5...

Powered by Google App Engine
This is Rietveld 408576698