Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6916)

Unified Diff: chrome/common/features.gni

Issue 2769483002: Don't check is_ios in chrome/, it's always false there. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_repack_locales.gni ('k') | chrome/common/net/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/features.gni
diff --git a/chrome/common/features.gni b/chrome/common/features.gni
index a2c22fa7f8eb1f4a6f2eb07f6f68b3cbee352a1a..bcf9f45f710bc0b916b561af2946b52bde054c69 100644
--- a/chrome/common/features.gni
+++ b/chrome/common/features.gni
@@ -14,18 +14,20 @@ import("//ppapi/features/features.gni")
import("//printing/features/features.gni")
import("//ui/base/ui_features.gni")
+assert(!is_ios, "Chromium/iOS shouldn't use anything in //chrome")
+
# Please keep features in alphabetical order.
declare_args() {
enable_app_list = is_chromeos
# Enables support for background apps.
- enable_background = !is_ios && !is_android && !is_chromecast
+ enable_background = !is_android && !is_chromecast
# Enable the printing system dialog for platforms that support printing
# and have a system dialog.
enable_basic_print_dialog = enable_basic_printing && !is_chromeos
- enable_captive_portal_detection = !is_android && !is_ios && !is_chromecast
+ enable_captive_portal_detection = !is_android && !is_chromecast
# Google Now is disabled to prepare for its removal.
# http://crbug.com/539674
@@ -51,9 +53,9 @@ declare_args() {
# Enables use of the session service, which is enabled by default.
# Android stores them separately on the Java side.
- enable_session_service = !is_android && !is_ios && !is_chromecast
+ enable_session_service = !is_android && !is_chromecast
- enable_supervised_users = !is_ios && !is_chromecast
+ enable_supervised_users = !is_chromecast
# Enables vr shell UI development on local or remote page.
enable_vr_shell_ui_dev = false
« no previous file with comments | « chrome/chrome_repack_locales.gni ('k') | chrome/common/net/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698