Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2769333006: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome/browser (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by Byoungkwon Ko
Modified:
2 months, 3 weeks ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, mac-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome/browser BUG=644626 Review-Url: https://codereview.chromium.org/2769333006 Cr-Commit-Position: refs/heads/master@{#461174} Committed: https://chromium.googlesource.com/chromium/src/+/9ae73f4ee60f60cbe72e79d2684b2295571eec53

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/extensions/api/messaging/message_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/printer_capabilities_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
Trybot results:  linux_android_rel_ng   win_chromium_compile_dbg_ng   win_clang   win_chromium_x64_rel_ng   win_chromium_rel_ng   ios-simulator-xcode-clang   mac_chromium_compile_dbg_ng   mac_chromium_rel_ng   ios-simulator   linux_chromium_tsan_rel_ng   linux_chromium_rel_ng   ios-device   ios-device-xcode-clang   linux_chromium_chromeos_rel_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_asan_rel_ng   linux_chromium_compile_dbg_ng   chromeos_amd64-generic_chromium_compile_only_ng   chromeos_daisy_chromium_compile_only_ng   cast_shell_linux   chromium_presubmit   android_n5x_swarming_rel   linux_android_rel_ng   cast_shell_android   android_cronet   android_clang_dbg_recipe   android_compile_dbg   android_arm64_dbg_recipe   chromium_presubmit   win_chromium_rel_ng   win_chromium_x64_rel_ng   win_chromium_rel_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_chromeos_ozone_rel_ng   win_clang   win_chromium_x64_rel_ng   win_chromium_rel_ng   linux_chromium_chromeos_rel_ng   chromium_presubmit   linux_android_rel_ng   cast_shell_android   android_clang_dbg_recipe   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_asan_rel_ng   win_chromium_compile_dbg_ng   android_arm64_dbg_recipe   linux_chromium_tsan_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   mac_chromium_compile_dbg_ng   ios-device-xcode-clang   android_n5x_swarming_rel   chromeos_daisy_chromium_compile_only_ng   android_compile_dbg   ios-simulator-xcode-clang   ios-device   linux_chromium_compile_dbg_ng   ios-simulator   linux_chromium_rel_ng   android_cronet   cast_shell_linux   mac_chromium_rel_ng 
Commit queue not available (can’t edit this change).

Messages

Total messages: 18 (12 generated)
Byoungkwon Ko
PTAL
2 months, 3 weeks ago (2017-03-31 12:26:50 UTC) #10
Devlin
lgtm; thanks for the patch! :)
2 months, 3 weeks ago (2017-03-31 13:44:41 UTC) #11
msw - vacation june 8-27
c/b/ui lgtm
2 months, 3 weeks ago (2017-03-31 16:04:43 UTC) #12
Benoit L
On 2017/03/31 16:04:43, msw wrote: > c/b/ui lgtm predictors/ lgtm, thanks.
2 months, 3 weeks ago (2017-03-31 16:11:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769333006/1
2 months, 3 weeks ago (2017-03-31 16:16:43 UTC) #15
commit-bot: I haz the power
2 months, 3 weeks ago (2017-03-31 18:23:33 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9ae73f4ee60f60cbe72e79d2684b...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318