chrome/browser/ui/webui/print_preview/printer_capabilities_unittest.cc - Issue 2769333006: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome/browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview/printer_capabilities_unittest.cc

Issue 2769333006: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome/browser (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/print_preview/printer_capabilities_unittest.cc

diff --git a/chrome/browser/ui/webui/print_preview/printer_capabilities_unittest.cc b/chrome/browser/ui/webui/print_preview/printer_capabilities_unittest.cc

index 7ed0acddd2f0ced9838691d7775588d137fcac58..be7765328881bb596598836278b7fdecd3b0fbff 100644

--- a/chrome/browser/ui/webui/print_preview/printer_capabilities_unittest.cc

+++ b/chrome/browser/ui/webui/print_preview/printer_capabilities_unittest.cc

@@ -22,7 +22,7 @@ namespace {

void SettingsReply(std::unique_ptr<base::DictionaryValue>* out,

std::unique_ptr<base::DictionaryValue> reply) {

- out->reset(reply.release());

+ *out = std::move(reply);

}

std::unique_ptr<base::DictionaryValue> GetSettingsSynchronous(

« no previous file with comments | « chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm ('k') | no next file » | no next file with comments »