Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2769313002: android: Remove nativeIsSingleProcess (Closed)

Created:
3 years, 9 months ago by boliu
Modified:
3 years, 9 months ago
Reviewers:
Maria
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Remove nativeIsSingleProcess It's only used to guard a warning log message, which shouldn't be logged in the first place. BUG=689758 Review-Url: https://codereview.chromium.org/2769313002 Cr-Commit-Position: refs/heads/master@{#459284} Committed: https://chromium.googlesource.com/chromium/src/+/fcf25e5abf9f679d8717049e2d48f6d38bdd24ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M content/browser/child_process_launcher_helper_android.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java View 3 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
boliu
ptal got depressed abandoning my leak fix, so here's a small code removal CL to ...
3 years, 9 months ago (2017-03-23 22:55:01 UTC) #2
Maria
lgtm Don't feel bad about ChildProcess* stuff -- it's a raw deal. If you persist, ...
3 years, 9 months ago (2017-03-23 23:17:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769313002/1
3 years, 9 months ago (2017-03-23 23:19:24 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 23:53:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fcf25e5abf9f679d8717049e2d48...

Powered by Google App Engine
This is Rietveld 408576698