Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

Issue 2769313002: android: Remove nativeIsSingleProcess (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/child_process_launcher_helper_android.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
index 2433d7f062edb1e9332124136aa36232be38c9d2..84d38dacdde74fa1a6cb8b890489cb59842e7aad 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
@@ -814,7 +814,7 @@ public class ChildProcessLauncher {
Log.d(TAG, "stopping child connection: pid=%d", pid);
ChildProcessConnection connection = sServiceMap.remove(pid);
if (connection == null) {
- logPidWarning(pid, "Tried to stop non-existent connection");
+ // Can happen for single process.
return;
}
sBindingManager.clearConnection(pid);
@@ -829,13 +829,6 @@ public class ChildProcessLauncher {
return callbackType == CALLBACK_FOR_GPU_PROCESS ? new GpuProcessCallback() : null;
}
- static void logPidWarning(int pid, String message) {
- // This class is effectively a no-op in single process mode, so don't log warnings there.
- if (pid > 0 && !nativeIsSingleProcess()) {
- Log.w(TAG, "%s, pid=%d", message, pid);
- }
- }
-
@VisibleForTesting
public static ChildProcessConnection startForTesting(Context context, String[] commandLine,
FileDescriptorInfo[] filesToMap, ChildProcessCreationParams params) {
@@ -938,5 +931,4 @@ public class ChildProcessLauncher {
}
private static native void nativeOnChildProcessStarted(long clientContext, int pid);
- private static native boolean nativeIsSingleProcess();
}
« no previous file with comments | « content/browser/child_process_launcher_helper_android.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698