Enable noexcept on Windows, use for a few move constructors.

Enable noexcept on Windows, use for a few move constructors.

MSVC complains if you use noexcept with no exception handling mode specified (as we do).
This code disables the warning. noexcept on move constructors allows better optimizations
in some cases.
http://en.cppreference.com/w/cpp/language/noexcept_spec

Updates a few common classes' move constructors to use this.

Reland of https://codereview.chromium.org/2771643002 with landmine. There were some
reports of PCH headers not getting updated and the warning change no taking effect.
I investigated briefly but could not see why PCH dependencies are incorrect.

Review-Url: https://codereview.chromium.org/2769283002
Cr-Commit-Position: refs/heads/master@{#459455}
Committed: https://chromium.googlesource.com/chromium/src/+/f78cc27d15ccbd1fd0c5c93aa03b939cd89b9b89

[brettw, 2017-03-23 19:58:49]

Landmine

[brettw, 2017-03-23 19:59:35]

brettw@chromium.org changed reviewers:
+ scottmg@chromium.org

[brettw, 2017-03-23 19:59:35]

I'll land this evening so I don't clobber the bots during the busy time.

[scottmg, 2017-03-23 20:02:38]

lgtm

[brettw, 2017-03-24 05:02:33]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2017-03-24 05:03:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 06:44:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 06:44:56]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2017-03-24 14:58:07]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2017-03-24 14:58:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 16:36:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490367487153760,
"parent_rev": "4fab802da9defe20515b8da9ab72e9017bded970", "commit_rev":
"f78cc27d15ccbd1fd0c5c93aa03b939cd89b9b89"}

[commit-bot: I haz the power, 2017-03-24 16:37:33]

Description was changed from

==========
Enable noexcept on Windows, use for a few move constructors.

MSVC complains if you use noexcept with no exception handling mode specified (as
we do).
This code disables the warning. noexcept on move constructors allows better
optimizations
in some cases.
http://en.cppreference.com/w/cpp/language/noexcept_spec

Updates a few common classes' move constructors to use this.

Reland of https://codereview.chromium.org/2771643002 with landmine. There were
some
reports of PCH headers not getting updated and the warning change no taking
effect.
I investigated briefly but could not see why PCH dependencies are incorrect.
==========

to

==========
Enable noexcept on Windows, use for a few move constructors.

MSVC complains if you use noexcept with no exception handling mode specified (as
we do).
This code disables the warning. noexcept on move constructors allows better
optimizations
in some cases.
http://en.cppreference.com/w/cpp/language/noexcept_spec

Updates a few common classes' move constructors to use this.

Reland of https://codereview.chromium.org/2771643002 with landmine. There were
some
reports of PCH headers not getting updated and the warning change no taking
effect.
I investigated briefly but could not see why PCH dependencies are incorrect.

Review-Url: https://codereview.chromium.org/2769283002
Cr-Commit-Position: refs/heads/master@{#459455}
Committed:
https://chromium.googlesource.com/chromium/src/+/f78cc27d15ccbd1fd0c5c93aa03b...
==========

[commit-bot: I haz the power, 2017-03-24 16:37:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f78cc27d15ccbd1fd0c5c93aa03b...