Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Side by Side Diff: tools/gn/value.h

Issue 2769283002: Enable noexcept on Windows, use for a few move constructors. (Closed)
Patch Set: Landmine Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/get_landmines.py ('k') | tools/gn/value.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TOOLS_GN_VALUE_H_ 5 #ifndef TOOLS_GN_VALUE_H_
6 #define TOOLS_GN_VALUE_H_ 6 #define TOOLS_GN_VALUE_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 25 matching lines...) Expand all
36 Value(const ParseNode* origin, std::string str_val); 36 Value(const ParseNode* origin, std::string str_val);
37 Value(const ParseNode* origin, const char* str_val); 37 Value(const ParseNode* origin, const char* str_val);
38 // Values "shouldn't" have null scopes when type == Scope, so be sure to 38 // Values "shouldn't" have null scopes when type == Scope, so be sure to
39 // always set one. However, this is not asserted since there are some 39 // always set one. However, this is not asserted since there are some
40 // use-cases for creating values and immediately setting the scope on it. So 40 // use-cases for creating values and immediately setting the scope on it. So
41 // you can pass a null scope here if you promise to set it before any other 41 // you can pass a null scope here if you promise to set it before any other
42 // code gets it (code will generally assume the scope is not null). 42 // code gets it (code will generally assume the scope is not null).
43 Value(const ParseNode* origin, std::unique_ptr<Scope> scope); 43 Value(const ParseNode* origin, std::unique_ptr<Scope> scope);
44 44
45 Value(const Value& other); 45 Value(const Value& other);
46 Value(Value&& other); 46 Value(Value&& other) noexcept;
47 ~Value(); 47 ~Value();
48 48
49 Value& operator=(const Value& other); 49 Value& operator=(const Value& other);
50 Value& operator=(Value&& other) = default; 50 Value& operator=(Value&& other) = default;
51 51
52 Type type() const { return type_; } 52 Type type() const { return type_; }
53 53
54 // Returns a string describing the given type. 54 // Returns a string describing the given type.
55 static const char* DescribeType(Type t); 55 static const char* DescribeType(Type t);
56 56
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 std::string string_value_; 126 std::string string_value_;
127 bool boolean_value_; 127 bool boolean_value_;
128 int64_t int_value_; 128 int64_t int_value_;
129 std::vector<Value> list_value_; 129 std::vector<Value> list_value_;
130 std::unique_ptr<Scope> scope_value_; 130 std::unique_ptr<Scope> scope_value_;
131 131
132 const ParseNode* origin_; 132 const ParseNode* origin_;
133 }; 133 };
134 134
135 #endif // TOOLS_GN_VALUE_H_ 135 #endif // TOOLS_GN_VALUE_H_
OLDNEW
« no previous file with comments | « build/get_landmines.py ('k') | tools/gn/value.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698