Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2769133003: Revert of [scheduler] Add a CHECK for renderer main thread load metrics. (Closed)

Created:
3 years, 9 months ago by altimin
Modified:
3 years, 9 months ago
Reviewers:
Sami
CC:
chromium-reviews, blink-reviews, kinuko+watch, scheduler-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [scheduler] Add a CHECK for renderer main thread load metrics. (patchset #2 id:20001 of https://codereview.chromium.org/2720023003/ ) Reason for revert: Revert temporary CHECK back to DCHECK Original issue's description: > [scheduler] Add a CHECK for renderer main thread load metrics. > > Change DCHECK to CHECK in RendererScheduler's > Report{Foreground,Background}RendererThreadLoad. This should help pin > down strange anomalies from metrics. > > This patch should be Canary-channel only, and expected to be extremely > rare (less than 1 failure/day on Canary). Please revert without asking > if something goes wrong. > > BUG=693542 > > Review-Url: https://codereview.chromium.org/2720023003 > Cr-Commit-Position: refs/heads/master@{#453783} > Committed: https://chromium.googlesource.com/chromium/src/+/2100af86f06ded92e913c67723bbff9af08df307 TBR=skyostil@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=693542 Review-Url: https://codereview.chromium.org/2769133003 Cr-Commit-Position: refs/heads/master@{#459088} Committed: https://chromium.googlesource.com/chromium/src/+/b1087165c06ad1d860f4cab75f575a967814b2a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
altimin
Created Revert of [scheduler] Add a CHECK for renderer main thread load metrics.
3 years, 9 months ago (2017-03-23 13:55:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769133003/1
3 years, 9 months ago (2017-03-23 13:55:38 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 15:20:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b1087165c06ad1d860f4cab75f57...

Powered by Google App Engine
This is Rietveld 408576698